Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_iban: fix acc_number processing #31293

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
8 participants
@asaunier
Copy link
Contributor

asaunier commented Feb 20, 2019

Description of the issue/feature this PR addresses:

The following change introduced in Odoo 12 771e44e might be a little too radical.

If acc_number is not an IBAN, it might remove relevant elements of the string, used to analyze it. For instance for a swiss postal account number such as 46-110-7, the hyphens are removed, changing the acc_number to 461107.

Current behavior before PR:

Non-IBAN-like acc_number are unexpectedly transformed.

Desired behavior after PR is merged:

Non-IBAN-like acc_number are kept unchanged.
IBAN are beautified as expected.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@yvaucher
Copy link
Contributor

yvaucher left a comment

LGTM

Make sense to me that normalize_iban should be played only on iban account numbers.
Which restores the previous wanted behaviour.

@leemannd

This comment has been minimized.

Copy link
Contributor

leemannd commented Feb 26, 2019

@mart-e You might be interesed by this fix

@yvaucher

This comment has been minimized.

Copy link
Contributor

yvaucher commented Mar 12, 2019

ping @qdp-odoo

@simahawk

This comment has been minimized.

Copy link
Contributor

simahawk commented Mar 21, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 21, 2019

Dear all,

Thanks for the feedback. It seems legit to me. I would prefer @qdp-odoo to review it though, as at impacts the accounting modules.

FYI bst doesn't work at Odoo anymore ;)

Have a nice day,

Yannick.

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Mar 21, 2019

all good for me

@robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 21, 2019

Merged, thanks!

@asaunier asaunier deleted the asaunier:12.0-base_iban-acc_number-fix branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.