Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE] website_slides: improve layout of courses main pages and apply various fixes #31317

Closed
wants to merge 12 commits into
base: saas-12.2
from

Conversation

Projects
None yet
7 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Feb 21, 2019

Purpose of this merge is to provide several fixes related to new elearning
application [1]. This is second batch of fixes [2]. Those are mainly fixes
and improvements for front-end templates: layouting, clean design. Some
other fixes are also included, notably links and search capabilities.

See sub commits for more details.

Thanks to @awa-odoo @jem-odoo @stefanorigano @qmo-odoo @dbeguin
for their work as most of code come from cherry-picks.

Merge linked to task ID 1941250.

[1] eLearning feature: see task ID 1902304
[2] First batch of fixes landed at 5cec06b

@robodoo robodoo added the seen 🙂 label Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

@C3POdoo C3POdoo added the RD label Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

@robodoo robodoo removed the CI 🤖 label Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 21, 2019

jem-odoo and others added some commits Feb 20, 2019

[FIX] website_slides: bad xml ids on fields
Having bad xml ids, even on groups fields, causes crashes, even
when duplicating a record.

Commit linked to task ID 1941250 and PR #31317.
[FIX] website_slides: reload page when joining channel
When a user join a channel, the button 'join' changed and indicates
him that he is now member, but since the page is not refreshed, he
still can not access to slides displayed on the page.
This commit makes the widget trigger a page refresh.

Commit linked to task ID 1941250 and PR #31317.
[IMP] website_slides: improve main course page in documentation mode
Purpose is to clean a bit the card layout in documentation courses, notably

 * better layout for cards:
 * fetch (in controller as slides in course display are sudo-ed to display
   a card even if current user has no access) completion data and display it;

Commit linked to task ID 1941250 and PR #31317.
[FIX] website_slides: fix vote widget
Fix route of vote widget. Set it to auth=public so that instead of a crash
we have correct popup asking to login. Better than a SessionException, which
will not be displayed.

Another fix is done to avoid having one widget for all displayed like / dislike
buttons. Each slide should have its own vote widget.

Commit linked to task ID 1941250 and PR #31317.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch to 36f461d Feb 21, 2019

@robodoo robodoo removed the CI 🤖 label Feb 21, 2019

@tde-banana-odoo tde-banana-odoo changed the title [MERGE] website_slides: beware the new fixes monster ! [MERGE] website_slides: improve layout of courses main pages and apply various fixes Feb 21, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 21, 2019

@robodoo r+ rebase-merge

@robodoo robodoo added the r+ 👌 label Feb 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 21, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides: slightly improve demo data
Some addition to demo data, notably some members and a few more slides.
I bet there will be other commits improving demo data, one slide at a time.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] gamification: improve next rank icons
Background of icons should be transparent.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_profile: improve wording and fix typos
Manual backport of commit done in master at 20e48b8. It is interesting
to have those fixes in 12.2.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[REF] website_profile: add circular rank progress
Purpose of this commit is to add a circular progress around the rank of
a user when seing its profile. It allows to see at a glance advance for
next karma rank.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[REF] website_slides: improve design of "all courses" main pages
Containing notably

 * improve banners;
 * sidebar achievement design;
 * some sidebar adjustments;
 * adapt to circular rank progress the current user sidebar;
 * improve overall spacing;
 * improve cards design and size;
 * improve 'all courses' grid layout;
 * clean unused css and templates;

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: fix some styling issues on training course page
This commit do some small UI adjustment:

 * remove a potential doubled <hr/>;
 * remove a "mb8" to make views consistent whether you're a channel publisher
   or not;
 * add a specific parameter to see 'uncategorized' slides on a documentation
   channel as /category is a slug and does not allow Falsy values;

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: handle "My courses" to filter user's channels
Purpose: the "My courses" button on the slides home page now redirects the user
to the list of channels for which he is a member of.

In this commit we also clean a bit controller code to remove support of
category_id which makes no sense on a page displaying courses as categories
are not cross-courses, only course-specific.

A clear search icon is also added.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: fix some rating issues
Last review should be a comment. When fetching the last message on a course
the returned message can be a system notification (like "Channel created").
This is not what we want, mostly with the feature allowing to modify the body
of a message. This commit add restriction on the domain fetch last message.

Fix default rating value on popup widget. The conversation ratio (rating 1-10
and 5 stars) was not applied everywhere. So, the number of displayed stars was
doubled. This is now fixed.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: bad xml ids on fields
Having bad xml ids, even on groups fields, causes crashes, even
when duplicating a record.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: reload page when joining channel
When a user join a channel, the button 'join' changed and indicates
him that he is now member, but since the page is not refreshed, he
still can not access to slides displayed on the page.
This commit makes the widget trigger a page refresh.

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides: improve main course page in documentation mode
Purpose is to clean a bit the card layout in documentation courses, notably

 * better layout for cards:
 * fetch (in controller as slides in course display are sudo-ed to display
   a card even if current user has no access) completion data and display it;

Commit linked to task ID 1941250 and PR #31317.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: fix vote widget
Fix route of vote widget. Set it to auth=public so that instead of a crash
we have correct popup asking to login. Better than a SessionException, which
will not be displayed.

Another fix is done to avoid having one widget for all displayed like / dislike
buttons. Each slide should have its own vote widget.

Commit linked to task ID 1941250 and PR #31317.

robodoo added a commit that referenced this pull request Feb 21, 2019

[MERGE] website_slides: improve layout of courses main pages and appl…
…y various fixes

Purpose of this merge is to provide several fixes related to new elearning
application [1]. This is second batch of fixes [2]. Those are mainly fixes
and improvements for front-end templates: layouting, clean design. Some
other fixes are also included, notably links and search capabilities.

See sub commits for more details.

Thanks to @awa-odoo @jem-odoo @stefanorigano @qmo-odoo @dbeguin
for their work as most of code come from cherry-picks.

Merge linked to task ID 1941250.

[1] eLearning feature: see task ID 1902304
[2] First batch of fixes landed at 5cec06b

closes #31317
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 21, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 21, 2019

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:saas-12.2-elearning-fiximp-tde-3 branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.