Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][IMP] website_slides, website_*: email validation, comment restrictions with karma and search user profile #31321

Closed
wants to merge 5 commits into
base: saas-12.2
from

Conversation

Projects
None yet
6 participants
@dbeguin
Copy link
Contributor

dbeguin commented Feb 21, 2019

This merge is improving various points linked to eLearning.
Impacted modules: website_profile, website_forum, website_rating and website_slides

  • Move validation email from website_forum to website_profile to use the feature in both Forum and elearning. The purpose is to give first karma points to allow users to comment, vote, ... on slides.
  • Add search bar in 'all users' page. To do so, we needed to introduced the karma_position field.
  • Restrict comment, review and vote based on user's karma in eLearning (minimum karam required to review/vote/comment, like in forum). This feature required to add 3 stored fields, with the benediction of chs !
  • Fix channel completion computation and linked karma gain. Also provide some test on karma gain.

See sub commits for more details.

Task-1943788

@robodoo robodoo added the seen 🙂 label Feb 21, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 21, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 21, 2019

@C3POdoo C3POdoo added the RD label Feb 21, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 21, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 21, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@dbeguin dbeguin requested a review from tde-banana-odoo Feb 21, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[IMP] website(_profile,_forum,_slides): move validation email to prof…
…ile and use in forum and elearning

Email validation was necessary on the forum to be able to begin to use the forum
(ask or answer questions, vote, etc..)

As the new elearning also uses karma since 705376a,
the email validation is now also necessary in the eLearning platform.

This is why this commit is moving the email validation process to website_profile
and extend website_slides (eLearning) and website_forum to use this feature.

In function of where the user asked to send him the validation email,
the user is redirected on the forum or on the elearning when he clicks on
'Validate my account' in the received 'email validation' email.

Task ID : 1943788
Closes PR odoo#31321

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 22, 2019

@dbeguin dbeguin changed the title [IMP] website(_profile,_forum,_slides): move validation email to profile and use in forum and elearning [IMP] website(_profile,_forum,_slides): email validation in profile, forum and elearning and search on all users Feb 28, 2019

@robodoo robodoo added the CI 🤖 label Feb 28, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 28, 2019

@robodoo robodoo removed the CI 🤖 label Feb 28, 2019

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-website-profile-email-validation-dbe branch Feb 28, 2019

@robodoo robodoo added the CI 🤖 label Feb 28, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 15, 2019

Staging failed: ci/runbot on 25c89a5b8bd5dc4a9c3187269092238c4030df2e (view more at http://runbot.odoo.com/runbot/build/480504)

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 15, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 15, 2019

robodoo added a commit that referenced this pull request Mar 15, 2019

[MERGE][IMP] website_slides, website_*: email validation, comment res…
…trictions with karma and search user profile

This merge is improving various points linked to eLearning.
Impacted modules: website_profile, website_forum, website_rating and website_slides

- Move validation email from website_forum to website_profile to use the feature in both Forum and elearning. The purpose is to give first karma points to allow users to comment, vote, ... on slides.
- Add search bar in 'all users' page. To do so, we needed to introduced the `karma_position` field.
- Restrict comment, review and vote based on user's karma in eLearning (minimum karam required to review/vote/comment, like in forum). This feature required to add 3 stored fields, with the benediction of chs !
- Fix channel completion computation and linked karma gain. Also provide some test on karma gain.

See sub commits for more details.

Task-1943788

closes #31321

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>

@robodoo robodoo added merging 👷 and removed r+ 👌 CI 🤖 labels Mar 15, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 15, 2019

Staging failed: ci/runbot on 5415ac49da0423ce67122bb874db15a213265f69 (view more at http://runbot.odoo.com/runbot/build/480541)

@robodoo robodoo added error 🙅 and removed merging 👷 labels Mar 15, 2019

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 15, 2019

@robodoo retry please. On a du Cointreau !

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 15, 2019

robodoo added a commit that referenced this pull request Mar 15, 2019

[MERGE][IMP] website_slides, website_*: email validation, comment res…
…trictions with karma and search user profile

This merge is improving various points linked to eLearning.
Impacted modules: website_profile, website_forum, website_rating and website_slides

- Move validation email from website_forum to website_profile to use the feature in both Forum and elearning. The purpose is to give first karma points to allow users to comment, vote, ... on slides.
- Add search bar in 'all users' page. To do so, we needed to introduced the `karma_position` field.
- Restrict comment, review and vote based on user's karma in eLearning (minimum karam required to review/vote/comment, like in forum). This feature required to add 3 stored fields, with the benediction of chs !
- Fix channel completion computation and linked karma gain. Also provide some test on karma gain.

See sub commits for more details.

Task-1943788

closes #31321

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 15, 2019

@KangOl here is the PR with the 3 fields :)

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 15, 2019

robodoo r- not stable change

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 15, 2019

@robodoo r+
la faute a @mart-e putain !

robodoo added a commit that referenced this pull request Mar 15, 2019

[MERGE][IMP] website_slides, website_*: email validation, comment res…
…trictions with karma and search user profile

This merge is improving various points linked to eLearning.
Impacted modules: website_profile, website_forum, website_rating and website_slides

- Move validation email from website_forum to website_profile to use the feature in both Forum and elearning. The purpose is to give first karma points to allow users to comment, vote, ... on slides.
- Add search bar in 'all users' page. To do so, we needed to introduced the `karma_position` field.
- Restrict comment, review and vote based on user's karma in eLearning (minimum karam required to review/vote/comment, like in forum). This feature required to add 3 stored fields, with the benediction of chs !
- Fix channel completion computation and linked karma gain. Also provide some test on karma gain.

See sub commits for more details.

Task-1943788

closes #31321

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 15, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.