Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_unsplash: save image for res_model #31328

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
4 participants
@kebeclibre
Copy link
Contributor

kebeclibre commented Feb 21, 2019

Go on the website, create a new product from there
Click on the image to change it, select an unsplash image

Save your product.

Beforer this commit, the image wasn't saved because the qweb field image
did not know what to do with /unsplash/ urls

After this commit, the image is saved on the product (or any object...)

OPW 1936191

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@kebeclibre kebeclibre requested review from JKE-be and rdeodoo Feb 21, 2019

@robodoo robodoo added the seen 🙂 label Feb 21, 2019

@kebeclibre kebeclibre force-pushed the odoo-dev:12.0-unsplash-product-lpe branch Feb 21, 2019

@C3POdoo C3POdoo added the OE label Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

addons/web_unsplash/models/__init__.py Outdated
@@ -3,3 +3,4 @@

from . import res_config_settings
from . import res_users
from . import ir_qweb

This comment has been minimized.

@rdeodoo

rdeodoo Feb 21, 2019

Contributor

Missing new line but other than that I just tried and I could add the unsplash image as expected, works like a charm.

[FIX] web_unsplash: save image for res_model
Go on the website, create a new product from there
Click on the image to change it, select an unsplash image

Save your product.

Beforer this commit, the image wasn't saved because the qweb field image
did not know what to do with /unsplash/ urls

After this commit, the image is saved on the product (or any object...)

OPW 1936191

@kebeclibre kebeclibre force-pushed the odoo-dev:12.0-unsplash-product-lpe branch to e4a4175 Feb 22, 2019

@robodoo robodoo removed the CI 🤖 label Feb 22, 2019

@kebeclibre

This comment has been minimized.

Copy link
Contributor Author

kebeclibre commented Feb 22, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.