Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] hr_skills: Add demo data for all employees #31334

Closed
wants to merge 3 commits into
base: saas-12.2
from

Conversation

Projects
None yet
5 participants
@LucasLefevre
Copy link
Contributor

LucasLefevre commented Feb 21, 2019

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 21, 2019

@C3POdoo C3POdoo added the RD label Feb 21, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 21, 2019

@LucasLefevre LucasLefevre force-pushed the odoo-dev:saas-12.2-skills-demo-lul branch Feb 28, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 28, 2019

@tivisse tivisse force-pushed the odoo-dev:saas-12.2-skills-demo-lul branch Mar 7, 2019

@robodoo robodoo removed the CI 🤖 label Mar 7, 2019

@tivisse tivisse force-pushed the odoo-dev:saas-12.2-skills-demo-lul branch Mar 7, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 7, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 7, 2019

Because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward
@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 7, 2019

@robodoo rebase-ff r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 7, 2019

Merge method set to rebase and fast-forward

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 7, 2019

I'm sorry, @tivisse. This PR is already reviewed, reviewing it again is useless.

@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

xmo-odoo commented Mar 7, 2019

@tivisse could be more readable / shorter to use a CSV for the skills instead of a giant pile of XML

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 7, 2019

@robodoo robodoo removed the r+ 👌 label Mar 7, 2019

LucasLefevre and others added some commits Feb 21, 2019

@LucasLefevre LucasLefevre force-pushed the odoo-dev:saas-12.2-skills-demo-lul branch to c24b0a6 Mar 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 13, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 13, 2019

robodoo pushed a commit that referenced this pull request Mar 13, 2019

[FIX] hr_skills: Don't set 'false' line in no value to set
closes #31334

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

xmo-odoo commented Mar 13, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 13, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 13, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 13, 2019

@tivisse tivisse deleted the odoo-dev:saas-12.2-skills-demo-lul branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.