Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_crm_partner_assign: portal edit activity change activit… #31349

Closed
wants to merge 1 commit into
base: saas-12.1
from

Conversation

Projects
None yet
4 participants
@kebeclibre
Copy link
Contributor

kebeclibre commented Feb 22, 2019

…y type

On the portal, edit a Lead in order to make/edit the
next activity
Change the activity type

Before this commit, the modal closed when clicking on the selection field
This was because the wrong method was called

After this commit, the modal stays and the activity type is changed

OPW 1943428

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@kebeclibre kebeclibre requested review from tivisse and kea14 Feb 22, 2019

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@C3POdoo C3POdoo added the OE label Feb 22, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Feb 22, 2019

@kebeclibre kebeclibre force-pushed the odoo-dev:saas-12.1-portalassign-activity-lpe branch 2 times, most recently Feb 22, 2019

@kebeclibre

This comment has been minimized.

Copy link
Contributor Author

kebeclibre commented Feb 22, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 22, 2019

[FIX] website_crm_partner_assign: portal edit activity change activit…
…y type

On the portal, edit a Lead in order to make/edit the
next activity
Change the activity type

Before this commit, the modal closed when clicking on the selection field
This was because the wrong method was called

After this commit, the modal stays and the activity type is changed

OPW 1943428

closes #31349
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Staging failed: ci/runbot on 96d5b3a6f656ac6adaee04cd3f7b664d434a9c01 (view more at http://runbot.odoo.com/runbot/build/459956)

@kebeclibre

This comment has been minimized.

Copy link
Contributor Author

kebeclibre commented Feb 25, 2019

robodoo retry r+

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 25, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

I'm sorry, @kebeclibre. This PR is already reviewed, reviewing it again is useless.

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

Staging failed: ci/runbot on b079354a449d0508fea394c7783a43598609529d (view more at http://runbot.odoo.com/runbot/build/468436)

[FIX] website_crm_partner_assign: portal edit activity change activit…
…y type

On the portal, edit a Lead in order to make/edit the
next activity
Change the activity type

Before this commit, the modal closed when clicking on the selection field
This was because the wrong method was called

After this commit, the modal stays and the activity type is changed

OPW 1943428
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

Staging failed: ci/runbot on ed99ab83f2904abc03c87481a7421fdf548775aa (view more at http://runbot.odoo.com/runbot/build/468924)

@kebeclibre

This comment has been minimized.

Copy link
Contributor Author

kebeclibre commented Feb 26, 2019

robodoo r+ retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

I'm sorry, @kebeclibre. This PR is already reviewed, reviewing it again is useless.

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

Staging failed: ci/runbot on 9545b6152f62da4f74dc336a87636f74fac75e41 (view more at http://runbot.odoo.com/runbot/build/469270)

@kebeclibre

This comment has been minimized.

Copy link
Contributor Author

kebeclibre commented Feb 26, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 26, 2019

robodoo pushed a commit that referenced this pull request Feb 26, 2019

[FIX] website_crm_partner_assign: portal edit activity change activit…
…y type

On the portal, edit a Lead in order to make/edit the
next activity
Change the activity type

Before this commit, the modal closed when clicking on the selection field
This was because the wrong method was called

After this commit, the modal stays and the activity type is changed

OPW 1943428

closes #31349
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.