Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr: Fix wrong super call #31354

Closed
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
4 participants
@LucasLefevre
Copy link
Contributor

LucasLefevre commented Feb 22, 2019

super.message_post in _message_log is wrong.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@LucasLefevre

This comment has been minimized.

Copy link
Contributor Author

LucasLefevre commented Feb 22, 2019

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Feb 22, 2019

@robodoo robodoo added the r+ 👌 label Feb 22, 2019

@C3POdoo C3POdoo added the RD label Feb 22, 2019

@robodoo robodoo added the CI 🤖 label Feb 22, 2019

@LucasLefevre LucasLefevre force-pushed the odoo-dev:saas-12.2-message-profile-lul branch Feb 22, 2019

@LucasLefevre LucasLefevre force-pushed the odoo-dev:saas-12.2-message-profile-lul branch Feb 25, 2019

@robodoo robodoo added the CI 🤖 label Feb 25, 2019

@LucasLefevre

This comment has been minimized.

Copy link
Contributor Author

LucasLefevre commented Feb 27, 2019

Still not merged.
@tivisse can you @robodoo retry ? Thanks

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Feb 28, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 28, 2019

Staging failed: ci/runbot on 349d1b03609810cdeea7ba3ee5474317a782f5f5 (view more at http://runbot.odoo.com/runbot/build/471744)

@robodoo robodoo added error 🙅 and removed CI 🤖 labels Feb 28, 2019

[FIX] hr: Fix wrong super call
super.message_post in _message_log is wrong.

Also use `*args` and `**kwargs` in method parameters

@LucasLefevre LucasLefevre force-pushed the odoo-dev:saas-12.2-message-profile-lul branch to ae1650d Mar 5, 2019

@robodoo robodoo removed the error 🙅 label Mar 5, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 5, 2019

@robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 5, 2019

I'm sorry, @tivisse. Retry makes no sense when the PR is not in error.

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Mar 5, 2019

robodoo pushed a commit that referenced this pull request Mar 5, 2019

[FIX] hr: Fix wrong super call
super.message_post in _message_log is wrong.

Also use `*args` and `**kwargs` in method parameters

closes #31354

Signed-off-by: "Yannick Tivisse (yti)" <yti@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 5, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 5, 2019

@tivisse tivisse deleted the odoo-dev:saas-12.2-message-profile-lul branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.