Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account: filter aml on posted by default #31361

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@william-andre
Copy link
Contributor

william-andre commented Feb 22, 2019

Task 193992
The changes in account asset generate a lot of unposted aml in the future rendering hiding them by default necessary

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@C3POdoo C3POdoo added the RD label Feb 22, 2019

@robodoo robodoo added the CI 🤖 label Feb 22, 2019

@william-andre william-andre force-pushed the odoo-dev:master-asset-depreciation-journal-items-wan branch Feb 26, 2019

@robodoo robodoo removed the CI 🤖 label Feb 26, 2019

@william-andre william-andre marked this pull request as ready for review Feb 26, 2019

@robodoo robodoo added the CI 🤖 label Feb 26, 2019

@qdp-odoo
Copy link
Contributor

qdp-odoo left a comment

beware of the copy/paste

Show resolved Hide resolved addons/account/data/service_cron.xml Outdated
Show resolved Hide resolved addons/account/data/service_cron.xml
addons/account/views/account_view.xml Outdated
@@ -1425,7 +1425,7 @@
</field>
</record>
<record id="view_account_move_line_filter" model="ir.ui.view">
<field name="name">Journal Items</field>
<field name="name">account.move.line.search</field>

This comment has been minimized.

@qdp-odoo

qdp-odoo Mar 6, 2019

Contributor

this is unexpected. Any good reason to do so?

It might look harmless but, if I'm not wrong, changing the name of a view might also change the value of it in the breacrumb if the action has no name. So it isn't that safe.

and I like to keep the diff minimal

This comment has been minimized.

@william-andre

william-andre Mar 7, 2019

Author Contributor

It is the name of the search view, every other search view in the file has a name like that, I just thought that it is painful to grep in the file, but I'll change it if it really has side effects

@william-andre william-andre force-pushed the odoo-dev:master-asset-depreciation-journal-items-wan branch Mar 7, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 7, 2019

@@ -55,7 +55,7 @@
'data/payment_receipt_data.xml',
'wizard/setup_wizards_view.xml',
'views/account_onboarding_templates.xml',
'data/service_cron_reverse.xml',
'data/service_cron.xml',

This comment has been minimized.

@qdp-odoo

qdp-odoo Mar 7, 2019

Contributor

that file doesn't appear anymore as renamed in github, is it a bug?

This comment has been minimized.

@william-andre

william-andre Mar 7, 2019

Author Contributor

Eh... I just did a git commit --amend so it should't have happened I think ?

This comment has been minimized.

@qdp-odoo

qdp-odoo Mar 7, 2019

Contributor

ok if you didn't change anything, it's only github that mess it

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Mar 7, 2019

this PR is conflicting and needs a rebase

@william-andre william-andre force-pushed the odoo-dev:master-asset-depreciation-journal-items-wan branch Mar 7, 2019

@robodoo robodoo removed the CI 🤖 label Mar 7, 2019

@william-andre

This comment has been minimized.

Copy link
Contributor Author

william-andre commented Mar 7, 2019

@qdp-odoo done

@robodoo robodoo added the CI 🤖 label Mar 7, 2019

william-andre added some commits Feb 26, 2019

[IMP] account: filter aml on posted by default
Task 193992
The changes in account asset generate a lot of unposted aml in the future rendering hiding them by default necessary
[ADD] account: cron to post draft entries
Task 193992
The cron is used to post draft entries such as thos created by the module account_asset

@william-andre william-andre force-pushed the odoo-dev:master-asset-depreciation-journal-items-wan branch to 0151bf1 Mar 8, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.