Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] payment_payulatam: fix transaction reconsiliation #31365

Closed
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
3 participants
@pimodoo
Copy link
Contributor

pimodoo commented Feb 22, 2019

The reconsiliation code was looking for the aquirer_reference instead of
the reference to find out the corresponding transaction. Which leads to
not finding the corresponding transaction.

This behavior comes from the creation of the moule setting its own tests
in error in PR: #24802

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] payment_payulatam: fix transaction reconsiliation
The reconsiliation code was looking for the aquirer_reference instead of
the reference to find out the corresponding transaction. Which leads to
not finding the corresponding transaction.

This behavior comes from the creation of the moule setting its own tests
in error in PR: #24802

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@C3POdoo C3POdoo added the RD label Feb 22, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor Author

pimodoo commented Feb 22, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 22, 2019

[FIX] payment_payulatam: fix transaction reconsiliation
The reconsiliation code was looking for the aquirer_reference instead of
the reference to find out the corresponding transaction. Which leads to
not finding the corresponding transaction.

This behavior comes from the creation of the moule setting its own tests
in error in PR: #24802

closes #31365
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Staging failed: ci/runbot on 28525d5320fc573cff5615b0001d1c1064ce998a (view more at http://runbot.odoo.com/runbot/build/459907)

@pimodoo

This comment has been minimized.

Copy link
Contributor Author

pimodoo commented Feb 25, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

Staging failed: ci/runbot on 6c4adacda79c1f3ea9baf867ea6f74da743be296 (view more at http://runbot.odoo.com/runbot/build/468694)

@robodoo robodoo added error 🙅 and removed CI 🤖 labels Feb 25, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor Author

pimodoo commented Feb 27, 2019

robodoo retry

robodoo pushed a commit that referenced this pull request Feb 27, 2019

[FIX] payment_payulatam: fix transaction reconsiliation
The reconsiliation code was looking for the aquirer_reference instead of
the reference to find out the corresponding transaction. Which leads to
not finding the corresponding transaction.

This behavior comes from the creation of the moule setting its own tests
in error in PR: #24802

closes #31365
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 28, 2019

Staging failed: ci/runbot on 1abc804cec9aaf44e4834336857af168f5efe680 (view more at http://runbot.odoo.com/runbot/build/471783)

@robodoo robodoo added the error 🙅 label Feb 28, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor Author

pimodoo commented Feb 28, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 28, 2019

Staging failed: ci/runbot on 83774cda81be26e9d07d159f8236abe571470f9d (view more at http://runbot.odoo.com/runbot/build/471815)

@robodoo robodoo added error 🙅 and removed CI 🤖 labels Feb 28, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor Author

pimodoo commented Mar 1, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 1, 2019

robodoo pushed a commit that referenced this pull request Mar 1, 2019

[FIX] payment_payulatam: fix transaction reconsiliation
The reconsiliation code was looking for the aquirer_reference instead of
the reference to find out the corresponding transaction. Which leads to
not finding the corresponding transaction.

This behavior comes from the creation of the moule setting its own tests
in error in PR: #24802

closes #31365
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 1, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 1, 2019

@pimodoo pimodoo deleted the odoo-dev:saas-12.2-fix-payment_payulatam-pim branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.