Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] board: clicking on a pivot cell in dashboard #31367

Closed
wants to merge 1 commit into
base: saas-12.1
from

Conversation

Projects
None yet
5 participants
@aab-odoo
Copy link
Contributor

aab-odoo commented Feb 22, 2019

Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c1.

Issue reported on the saas-12.1 migration pad.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@aab-odoo aab-odoo requested a review from Polymorphe57 Feb 22, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor Author

aab-odoo commented Feb 22, 2019

robodoo delegate=Polymorphe57

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@Polymorphe57

This comment has been minimized.

Copy link
Contributor

Polymorphe57 commented Feb 22, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 22, 2019

@C3POdoo C3POdoo added the RD label Feb 22, 2019

[FIX] board: clicking on a pivot cell in dashboard
Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c1.

Issue reported on the saas-12.1 migration pad.

@aab-odoo aab-odoo force-pushed the odoo-dev:saas-12.1-board-fix-aab branch to fd96d2f Feb 26, 2019

@robodoo robodoo removed the r+ 👌 label Feb 26, 2019

@Polymorphe57

This comment has been minimized.

Copy link
Contributor

Polymorphe57 commented Feb 26, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 26, 2019

[FIX] board: clicking on a pivot cell in dashboard
Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c1.

Issue reported on the saas-12.1 migration pad.

closes #31367

robodoo pushed a commit that referenced this pull request Feb 26, 2019

[FIX] board: clicking on a pivot cell in dashboard
Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c1.

Issue reported on the saas-12.1 migration pad.

closes #31367
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

Staging failed: ci/runbot on 692204139f6846aaeea5088bf244ff18c330145d (view more at http://runbot.odoo.com/runbot/build/470221)

@d-fence

This comment has been minimized.

Copy link
Contributor

d-fence commented Feb 27, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 27, 2019

robodoo pushed a commit that referenced this pull request Feb 27, 2019

[FIX] board: clicking on a pivot cell in dashboard
Before this rev., it crashed when the user clicked on a pivot cell
in the dashboard, whereas it should have performed a do_action to
open the records in a list view.

This was due to a leftover event handler (with the handler function
being actually removed) in commit 38dc5c1.

Issue reported on the saas-12.1 migration pad.

closes #31367
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 27, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.