Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of issues in l10n_de_skr03 and l10n_de_skr04 #31389

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@tv-openbig
Copy link
Contributor

commented Feb 25, 2019

Description of the issue/feature this PR addresses:

  • some accounts have wrong tax tag mapping
  • some fiscal positions doesn’t work properly (mapping of taxes, right
    tax keys, right accounts)
  • missing fiscal position „domestic partners“ in order to allow
    automatic selection of the right fiscal position if it is a doemstic
    partner and to make it more clear for customers, otherwise they might
    wonder why fiscal position field is empty for domestic partners.
  • issue with fiscal position „Geschäftspartner EU (ohne USt.-ID) to
    detect the right account, tax, tax tags if we sell to a customer / buy
    from a supplier located in the EU without valid VAT-ID (for example
    private people.)
  • issue with fiscal position „Geschäftspartner Ausland“ to detect the
    right account, tax, tax tags if we sell to a customer / buy from a
    supplier not located in the EU.

Impacted versions:

  • 11.0 (12.0)

Steps to reproduce:

  1. create a new customer / supplier invoice and don’t select a product
    in order
    to edit just the description field and enter the account field by hand.
    Do that on customer invoices with SKR03 accounting plan for the
    accounts:
    8140,8194,8310,8315,8331,8336,8337,8514,8515,8574,8575,8609,8701,8702,87
    03,8704,8725,8726,8741,8746,8808,8827,8828,8919

If you have accounting plan SKR04 than take the corresponding accounts:
4139,4140,4310,4315,4331,4336,4337,4565,4574,4575,4702,4704,4725,4726,47
41,4746,4841,6888,4639,4844,4848
For supplier invoices the accounts are for SKR03:
3066, 3067, 3430, 3435, 3550,3551
… for SKR04:
5166, 5167, 5430, 5435, 5550, 5551

  1. check the tax filled by onchange function in the invoice line’s
    field tax (account, tax, tax tags).

  2. Define partners which you would assign to the two fiscal positions
    „Geschäftspartner Ausland“ and „Geschäftspartner EU (ohne Ust-ID)“.
    Create customer invoice / supplier invoice for both partner types.

Current behavior before PR:
The onchange detects a tax for the account, but the proposed tax is
wrong (if we test in customer / supplier invoices to enter the invoice
lines without selection of a product).
The fiscal position „Geschäftspartner Ausland“ and „Geschäftspartner
EU (ohne Ust-ID)“ doesn’t map properly in all cases the correct
accounts, taxes, tax tags …

Desired behavior after PR is merged:
The manual selection of the mentioned accounts should evaluate the
right taxes provided by the onchange functionality of the invoice line.
Some fiscal positions should be detected automatically by country
(domestic) or by country group (eu partners).
The selected or autoamtically detected fiscal position should map to
the right tax, tax tag, accounts in order to finally get a proper
VAT-report.

--
I confirm I have signed the CLA and read the PR guidelines at
www.odoo.com/submit-pr

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Fix of issues in l10n_de_skr03 and l10n_de_skr04
Description of the issue/feature this PR addresses:

* some accounts have wrong tax tag mapping
* some fiscal positions doesn’t work properly (mapping of taxes, right
tax keys, right accounts)
* missing fiscal position „domestic partners“ in order to allow
automatic selection of the right fiscal position if it is a doemstic
partner and to make it more clear for customers, otherwise they might
wonder why fiscal position field is empty for domestic partners.
* issue with fiscal position „Geschäftspartner EU (ohne USt.-ID) to
detect the right account, tax, tax tags if we sell to a customer / buy
from a supplier  located in the EU without valid VAT-ID (for example
private people.)
* issue with fiscal position „Geschäftspartner Ausland“ to detect the
right account, tax, tax tags  if we sell to a customer / buy from a
supplier not located in the EU.

Impacted versions:

 - 11.0 (12.0)

Steps to reproduce:

 1. create a new customer / supplier invoice and don’t select a product
in order
to edit just the description field and enter the account field by hand.
Do that on customer invoices with SKR03 accounting plan for the
accounts:
8140,8194,8310,8315,8331,8336,8337,8514,8515,8574,8575,8609,8701,8702,87
03,8704,8725,8726,8741,8746,8808,8827,8828,8919

If you have accounting plan SKR04 than take the corresponding accounts:
4139,4140,4310,4315,4331,4336,4337,4565,4574,4575,4702,4704,4725,4726,47
41,4746,4841,6888,4639,4844,4848
For supplier invoices the accounts are for SKR03:
3066, 3067, 3430, 3435, 3550,3551
… for SKR04:
5166, 5167, 5430, 5435, 5550, 5551

 2. check the tax filled by onchange function in the invoice line’s
field tax (account, tax, tax tags).

3. Define partners which you would assign to the two fiscal positions
„Geschäftspartner Ausland“ and „Geschäftspartner EU (ohne Ust-ID)“.
Create customer invoice / supplier invoice for both partner types.

Current behavior before PR:
The onchange detects a tax for the account, but the proposed tax is
wrong (if we test in customer / supplier invoices to enter the invoice
lines without selection of a product).
The fiscal position „Geschäftspartner Ausland“ and  „Geschäftspartner
EU (ohne Ust-ID)“ doesn’t map properly in all cases the correct
accounts, taxes, tax tags …

Desired behavior after PR is merged:
The manual selection of the mentioned accounts should evaluate the
right taxes provided by the onchange functionality of the invoice line.
Some fiscal positions should be detected automatically by country
(domestic) or by country group (eu partners).
The selected or autoamtically detected fiscal position should map to
the right tax, tax tag, accounts in order to finally get a proper
VAT-report.

--
I confirm I have signed the CLA and read the PR guidelines at
www.odoo.com/submit-pr
@HaGuesto
Copy link

left a comment

code review LGTM, nothing to complain

functional review
To test there are a few extra steps needed:

  • Install the sale module.
  • Enable the Show all account feature setting for your user.

Result:

  • I tested all tax tags and they are conform with the Umsatzsteuer Voranmeldung.
  • For the given accounts the right taxes are loaded by the onchange function.

@jco-odoo jco-odoo self-assigned this Apr 11, 2019

@jco-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@nim-odoo Can we merge this? (there is a pr for 12.0 too for the forward-port)

@nim-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@nim-odoo Can we merge this? (there is a pr for 12.0 too for the forward-port)

Does it mean we shouldn't forward-port this?

nim-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 15, 2019

[FIX] l10n_de_skr03, l10n_de_skr04: tax and fpos
* Some accounts have wrong tax tag mapping
* Some fiscal positions don't work properly (mapping of taxes, right tax
  keys, right accounts)
* Missing fiscal position "domestic partners" in order to allow
  automatic selection of the right fiscal position if it is a doemstic
  partner and to make it more clear for customers, otherwise they might
  wonder why fiscal position field is empty for domestic partners.
* Issue with fiscal position "Geschäftspartner EU (ohne USt.-ID)" to
  detect the right account, tax, tax tags if we sell to a customer / buy
  from a supplier  located in the EU without valid VAT-ID (for example
  private people)
* Issue with fiscal position "Geschäftspartner Ausland" to detect the
  right account, tax, tax tags  if we sell to a customer / buy from a
  supplier not located in the EU.

Closes odoo#31389
@jco-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@nim-odoo The main change between the two is that the accounts are in xml here and not in csv, so it might be easier to take the other branch to do the forward-port. I saw it was not converted in saas-11.5

@nim-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@jco-odoo what is the other PR targeting v12?

@jco-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@nim-odoo Sorry, I thought it had been referenced here. #31392

@KangOl KangOl closed this in c2f071c Apr 15, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.