Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] lunch: make it work on mobile #31428

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@pparidans
Copy link
Contributor

pparidans commented Feb 26, 2019

This module didn't worked on mobile: user cannot select the products or
see their cart.

This commit reworks the LunchKanbanWidget template and introduces a
dedicated template for mobile. This template introduces a button at the
bottom of the screen to toggle the "cart" widget on mobile (hiding it by
default).

It tries to make the best use of the existing Bootstrap classes allowing
to have a more responsive layout and reducing the custom CSS required by
this module (both in desktop and in mobile).

This commit adds a decent JS tests-suite (mobile & desktop) to this
module as the existing one left substential parts of the UI untested
(opening wizard when clicking on a kanban record, cart's lines content,
clear cart button, widget structure and content based on the state...).
Those tests are also less based on DOM nodes order/tag names and use
instead dedicated classnames.

It also modifies the LunchKanbanRecord click handling to had a dedicated
event handler instead of overriding the default _onGlobalClick() and
make it more testable.

Finally this commit also remove unused code.

Task ID: 1945032

@robodoo robodoo added the seen 🙂 label Feb 26, 2019

@C3POdoo C3POdoo added the RD label Feb 26, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch 5 times, most recently Feb 27, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 28, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch Mar 1, 2019

@robodoo robodoo removed the CI 🤖 label Mar 1, 2019

@pparidans pparidans requested a review from adr-odoo Mar 1, 2019

@pparidans pparidans changed the title [WIP] lunch: mobile [FIX] lunch: make it work on mobile Mar 1, 2019

@robodoo robodoo added the CI 🤖 label Mar 1, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch Mar 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@pparidans

This comment has been minimized.

Copy link
Contributor Author

pparidans commented Mar 13, 2019

Got the 👍 from EST. 😎

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch to 9fbba9c Mar 13, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 13, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch from 9fbba9c Mar 15, 2019

@robodoo robodoo removed the CI 🤖 label Mar 15, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch to 18e9556 Mar 15, 2019

@robodoo robodoo added the CI 🤖 label Mar 15, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch from 18e9556 to 7f5092b Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch from 7f5092b to 5d9a666 Mar 18, 2019

@pparidans pparidans requested a review from VincentSchippefilt Mar 18, 2019

@pparidans

This comment has been minimized.

Copy link
Contributor Author

pparidans commented Mar 18, 2019

As requested by @VincentSchippefilt a proper JS test-suite (at least I hope so 😜 ) has been added...

@adr-odoo @VincentSchippefilt : let's fire 🔥 up the reviews! I'm ready 👨‍🚒

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

[FIX] lunch: make it work on mobile
This module didn't worked on mobile: user cannot select the products or
see their cart.

This commit reworks the LunchKanbanWidget template and introduces a
dedicated template for mobile. This template introduces a button at the
bottom of the screen to toggle the "cart" widget on mobile (hiding it by
default).

It tries to make the best use of the existing Bootstrap classes allowing
to have a more responsive layout and reducing the custom CSS required by
this module (both in desktop and in mobile).

This commit adds a decent JS tests-suite (mobile & desktop) to this
module as the existing one left substential parts of the UI untested
(opening wizard when clicking on a kanban record, cart's lines content,
clear cart button, widget structure and content based on the state...).
Those tests are also less based on DOM nodes order/tag names and use
instead dedicated classnames.

It also modifies the LunchKanbanRecord click handling to had a dedicated
event handler instead of overriding the default _onGlobalClick() and
make it more testable.

Task ID: 1945032

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-lunch-mobile-app branch from 5d9a666 to 0dfcf1b Mar 19, 2019

@robodoo robodoo removed the CI 🤖 label Mar 19, 2019

@adr-odoo
Copy link
Contributor

adr-odoo left a comment

@robodoo rebase-merge r+

@robodoo robodoo added the r+ 👌 label Mar 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 label Mar 19, 2019

robodoo added a commit that referenced this pull request Mar 19, 2019

[FIX] lunch: make it work on mobile
This module didn't worked on mobile: user cannot select the products or
see their cart.

This commit reworks the LunchKanbanWidget template and introduces a
dedicated template for mobile. This template introduces a button at the
bottom of the screen to toggle the "cart" widget on mobile (hiding it by
default).

It tries to make the best use of the existing Bootstrap classes allowing
to have a more responsive layout and reducing the custom CSS required by
this module (both in desktop and in mobile).

This commit adds a decent JS tests-suite (mobile & desktop) to this
module as the existing one left substential parts of the UI untested
(opening wizard when clicking on a kanban record, cart's lines content,
clear cart button, widget structure and content based on the state...).
Those tests are also less based on DOM nodes order/tag names and use
instead dedicated classnames.

It also modifies the LunchKanbanRecord click handling to had a dedicated
event handler instead of overriding the default _onGlobalClick() and
make it more testable.

Finally this commit also remove unused code.

Task ID: 1945032

closes #31428

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Staging failed: ci/runbot on 0bc249f79db37e003fa0221abc4732b47cb764e9 (view more at http://runbot.odoo.com/runbot/build/482032)

@pparidans

This comment has been minimized.

Copy link
Contributor Author

pparidans commented Mar 19, 2019

@robodoo retry

robodoo added a commit that referenced this pull request Mar 19, 2019

[FIX] lunch: make it work on mobile
This module didn't worked on mobile: user cannot select the products or
see their cart.

This commit reworks the LunchKanbanWidget template and introduces a
dedicated template for mobile. This template introduces a button at the
bottom of the screen to toggle the "cart" widget on mobile (hiding it by
default).

It tries to make the best use of the existing Bootstrap classes allowing
to have a more responsive layout and reducing the custom CSS required by
this module (both in desktop and in mobile).

This commit adds a decent JS tests-suite (mobile & desktop) to this
module as the existing one left substential parts of the UI untested
(opening wizard when clicking on a kanban record, cart's lines content,
clear cart button, widget structure and content based on the state...).
Those tests are also less based on DOM nodes order/tag names and use
instead dedicated classnames.

It also modifies the LunchKanbanRecord click handling to had a dedicated
event handler instead of overriding the default _onGlobalClick() and
make it more testable.

Finally this commit also remove unused code.

Task ID: 1945032

closes #31428

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 19, 2019

@adr-odoo adr-odoo deleted the odoo-dev:saas-12.2-lunch-mobile-app branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.