Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] (website_)survey: hide header/footer when taking a certification #31503

Conversation

Projects
None yet
4 participants
@awa-odoo
Copy link
Contributor

commented Feb 28, 2019

Purpose

We need to hide header and footer of survey and website layouts when
the user is taking a certification ("certificate" field of survey.survey).

This is done to have a more "immersive" taking and avoid that the user
clicks on other links in the layout header or footer and moves to another page.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Feb 28, 2019

@C3POdoo C3POdoo added the RD label Feb 28, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:saas-12.2-survey-hide-header-footer-certif-awa branch from bcd0430 to 7c18639 Mar 27, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 27, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:saas-12.2-survey-hide-header-footer-certif-awa branch from 7c18639 to df33ced Mar 27, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 27, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:saas-12.2-survey-hide-header-footer-certif-awa branch from df33ced to 8e3f233 Apr 4, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 4, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:saas-12.2-survey-hide-header-footer-certif-awa branch from 8e3f233 to 0bc2eb1 Apr 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 12, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@robodoo robodoo added the r+ 👌 label Apr 23, 2019

robodoo pushed a commit that referenced this pull request Apr 23, 2019

[IMP] (website_)survey: hide header/footer when taking a certification
Purpose
=======

We need to hide header and footer of survey and website layouts when
the user is taking a certification ("certificate" field of survey.survey).

This is done to have a more "immersive" taking and avoid that the user
clicks on other links in the layout header or footer and moves to another page.

closes #31503

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Staging failed: ci/runbot on bdf690adef3b0c4d1b471b7870b466efae40fff4 (view more at http://runbot.odoo.com/runbot/build/505338)

[IMP] (website_)survey: hide header/footer when taking a certification
Purpose
=======

We need to hide header and footer of survey and website layouts when
the user is taking a certification ("certificate" field of survey.survey).

This is done to have a more "immersive" taking and avoid that the user
clicks on other links in the layout header or footer and moves to another page.

@awa-odoo awa-odoo force-pushed the odoo-dev:saas-12.2-survey-hide-header-footer-certif-awa branch from 0bc2eb1 to 413f8ba Apr 24, 2019

@awa-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@tde-banana-odoo Just rebased the branch if you want to try again.

@robodoo robodoo added CI 🤖 and removed error 🙅 labels Apr 24, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@robodoo robodoo added the r+ 👌 label Apr 24, 2019

robodoo pushed a commit that referenced this pull request Apr 24, 2019

[IMP] (website_)survey: hide header/footer when taking a certification
Purpose
=======

We need to hide header and footer of survey and website layouts when
the user is taking a certification ("certificate" field of survey.survey).

This is done to have a more "immersive" taking and avoid that the user
clicks on other links in the layout header or footer and moves to another page.

closes #31503

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.