Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created l10n_tr_states addon to seed provinces of Turkey #31592

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@cantecim
Copy link
Contributor

commented Mar 5, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:
There are no data provinces of Turkey

Desired behavior after PR is merged:
Added an auto-installing localization addon to seed them

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added seen 🙂 CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Hi,

Could you add them in the existing l10n_tr module instead?

@cantecim

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

I think someone might need the data without installing l10n_tr. It is an auto-installing addon to make them ready on fresh database initialization

@mart-e

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Good point and actually we are working on a proper solution for per-country data at
https://github.com/odoo-dev/odoo/tree/master-country-specific-data-l10n_be-pla
It is not ready yet but hopefully, we will get that for v13.
So you can either wait for that to be ready to be included in the future version of Odoo or add them in l10n_tr.

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 21, 2019

@cantecim

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Hello @mart-e, I've done them

@mart-e mart-e force-pushed the cantecim:11.0 branch from 5f8cd2d to 3750bf8 Mar 25, 2019

@robodoo robodoo removed the CI 🤖 label Mar 25, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Thanks for the update. I have squashed the commits.

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 25, 2019

[ADD] l10n_tr: add provinces of Turkey
closes #31592

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.