Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account: add ocr to customer invoices #31655

Closed

Conversation

Projects
None yet
4 participants
@william-andre
Copy link
Contributor

commented Mar 7, 2019

Task 1942983
Accounting firms need to upload PDF of customer invoices and refunds (not only vendor bills).

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Mar 7, 2019

@C3POdoo C3POdoo added the RD label Mar 7, 2019

@robodoo robodoo added the CI 🤖 label Mar 7, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from ca6df55 to 9e75029 Mar 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 15, 2019

@qdp-odoo
Copy link
Contributor

left a comment

  • do not change the factur-x export (we'll never export vendor bills in factur-x)
  • change the factur-x import: based on the context 👎 (edit: no, we should compare the seller name/vat with the companies name/vat) to decide to import the file as vendor bill or customer invoice (fields to import aren't the same)
  • remove 'import customer invoices' from dashboard: this button will be visible only in list view by default

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from 9e75029 to 45ecd12 Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from 45ecd12 to dad9b77 Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from dad9b77 to a19a9d9 Mar 27, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 27, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from a19a9d9 to b2e900c Apr 1, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 1, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from b2e900c to eb17337 Apr 2, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 2, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from eb17337 to 9c37b45 Apr 2, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 2, 2019

@qdp-odoo
Copy link
Contributor

left a comment

some minor comments

Show resolved Hide resolved addons/account_facturx/models/account_invoice.py
Show resolved Hide resolved addons/account_facturx/models/account_invoice.py Outdated
Show resolved Hide resolved addons/account_facturx/models/account_invoice.py Outdated

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from 9c37b45 to 0f06bd4 Apr 3, 2019

@robodoo robodoo removed the CI 🤖 label Apr 3, 2019

@william-andre william-andre changed the base branch from master to staging.saas-12.3 Apr 3, 2019

@william-andre william-andre changed the base branch from staging.saas-12.3 to saas-12.3 Apr 3, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from 0f06bd4 to 9b4150e Apr 3, 2019

@robodoo robodoo added the CI 🤖 label Apr 3, 2019

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from 9b4150e to df3ecc0 Apr 4, 2019

@robodoo robodoo removed the CI 🤖 label Apr 4, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

ok for the diff. the only remaining thing is the commit message to improve/fix

something like

[IMP] account, account_facturex: import customer invoices in XML

Accounting firms need to upload PDF of customer invoices and refunds (not only vendor bills). For that, we now allow to
* define a mail alias on sale journals
* upload customer invoices from list view
* check for `facture X` XML attachments in PDF of customer invoices

Was part of task 1942983
[IMP] account, account_facturex: import customer invoices in XML
Task 1942983

Accounting firms need to upload PDF of customer invoices and refunds (not only vendor bills). For that, we now allow to
* define a mail alias on sale journals
* upload customer invoices from list view
* check for `facture X` XML attachments in PDF of customer invoices

@william-andre william-andre force-pushed the odoo-dev:master-ocr-customer-invoice-wan branch from df3ecc0 to 416a2b4 Apr 4, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@robodoo robodoo added the r+ 👌 label Apr 4, 2019

robodoo pushed a commit that referenced this pull request Apr 4, 2019

[IMP] account, account_facturex: import customer invoices in XML
Task 1942983

Accounting firms need to upload PDF of customer invoices and refunds (not only vendor bills). For that, we now allow to
* define a mail alias on sale journals
* upload customer invoices from list view
* check for `facture X` XML attachments in PDF of customer invoices

closes #31655

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.