Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: properly start website edit mode as restricted editor #31702

Closed
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
5 participants
@Zinston
Copy link

Zinston commented Mar 8, 2019

It was impossible to open the website's edit mode as a user with "restricted editor" permissions. The reason was that wysiwyg_multizone was trying to manipulate data that is not injected into the html node
when editable is false (see website.layout template).

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Mar 8, 2019

@Zinston Zinston requested a review from ged-odoo Mar 8, 2019

@robodoo robodoo added the CI 🤖 label Mar 8, 2019

@C3POdoo C3POdoo added the RD label Mar 8, 2019

@Zinston Zinston requested review from pparidans and removed request for ged-odoo Mar 13, 2019

@Zinston Zinston force-pushed the odoo-dev:saas-12.2-summernote-restricteduser-age branch Mar 14, 2019

@robodoo robodoo removed the CI 🤖 label Mar 14, 2019

@Zinston Zinston force-pushed the odoo-dev:saas-12.2-summernote-restricteduser-age branch 3 times, most recently to 397248e Mar 14, 2019

@Zinston

This comment has been minimized.

Copy link
Author

Zinston commented Mar 14, 2019

@pparidans I added a tour. It fails without the fix and passes with it, as it should ;-)

@Zinston Zinston force-pushed the odoo-dev:saas-12.2-summernote-restricteduser-age branch from 397248e to a64fca3 Mar 14, 2019

@robodoo robodoo added the CI 🤖 label Mar 14, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Mar 15, 2019

@Zinston thanks for the test, but do not forget to add test: true otherwise the tour will be shown to users 😉

@pparidans
Copy link
Contributor

pparidans left a comment

Also ok for me.
Waiting for the change from QSM before approving

[FIX] web_editor: properly start website edit mode as restricted editor
It was impossible to open the website's edit mode as a user with
"restricted editor" permissions. The reason was that wysiwyg_multizone
was trying to manipulate data that is not injected into the html node
when `editable` is false (see `website.layout` template).

@Zinston Zinston force-pushed the odoo-dev:saas-12.2-summernote-restricteduser-age branch from a64fca3 to c559680 Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@Zinston

This comment has been minimized.

Copy link
Author

Zinston commented Mar 18, 2019

@qsm-odoo Thanks for the feedback. Done.
@pparidans Ready ;-)

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

@pparidans
Copy link
Contributor

pparidans left a comment

@robodoo robodoo added the r+ 👌 label Mar 18, 2019

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[FIX] web_editor: properly start website edit mode as restricted editor
It was impossible to open the website's edit mode as a user with
"restricted editor" permissions. The reason was that wysiwyg_multizone
was trying to manipulate data that is not injected into the html node
when `editable` is false (see `website.layout` template).

closes #31702

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

@pparidans pparidans deleted the odoo-dev:saas-12.2-summernote-restricteduser-age branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.