Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] project,web: Added ability to set cover image on kanban #31731

Closed

Conversation

Projects
None yet
5 participants
@dja-odoo
Copy link
Contributor

dja-odoo commented Mar 11, 2019

Task : https://www.odoo.com/web#id=32108&model=project.task&view_type=form&menu_id=5195
Pad : https://pad.odoo.com/p/r.ebf5ce9cae9fb8be3445445c7ddd17e5

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Mar 11, 2019

@C3POdoo C3POdoo added the RD label Mar 11, 2019

@suh-odoo suh-odoo force-pushed the odoo-dev:master-web_studio-kanban-imp-vas branch from d050602 to ea89e38 Mar 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 18, 2019

@mge-odoo mge-odoo force-pushed the odoo-dev:master-web_studio-kanban-imp-vas branch from ea89e38 to b782bae Apr 10, 2019

@robodoo robodoo removed the CI 🤖 label Apr 10, 2019

@mge-odoo mge-odoo force-pushed the odoo-dev:master-web_studio-kanban-imp-vas branch 2 times, most recently from bd51d81 to 99e5c61 Apr 12, 2019

@robodoo robodoo added the CI 🤖 label Apr 15, 2019

@mge-odoo mge-odoo force-pushed the odoo-dev:master-web_studio-kanban-imp-vas branch from 99e5c61 to 639cde8 Apr 18, 2019

@robodoo robodoo removed the CI 🤖 label Apr 18, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor

mge-odoo commented Apr 18, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 18, 2019

'ci/runbot' failed on this reviewed PR.

1 similar comment
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 18, 2019

'ci/runbot' failed on this reviewed PR.

[MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

@mge-odoo mge-odoo force-pushed the odoo-dev:master-web_studio-kanban-imp-vas branch from 639cde8 to 5780119 Apr 18, 2019

@robodoo robodoo removed the r+ 👌 label Apr 18, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor

mge-odoo commented Apr 18, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2019

[MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

closes #31731

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>

robodoo pushed a commit that referenced this pull request Apr 18, 2019

[MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

closes #31731

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 18, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 18, 2019

Arcasias added a commit to odoo-dev/odoo that referenced this pull request Apr 19, 2019

[MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

closes odoo#31731

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.