[IMP] mail,*: remove useless field is_master_data
#31778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is a non-sense. By using the same logic, it should be added to any low level model. Replace the check by a simple verification of presence of an XMLID. A more generic opt-in solution should be integrated into ORM. Partially revert commits 0db0e66 and bbd64c2. See odoo#29257 odoo/enterprise#3550
|
ok |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2019
This field is a non-sense. By using the same logic, it should be added to any low level model. Replace the check by a simple verification of presence of an XMLID. A more generic opt-in solution should be integrated into ORM. Partially revert commits 0db0e66 and bbd64c2. See #29257 odoo/enterprise#3550 closes #31778 Signed-off-by: Christophe Simonis <chs@odoo.com>
|
Merged, thanks! |
|
It is great to remove a field defined on 10 records and therefore not being able to delete unused demo data about activity types. Was that really worth chiing a pendule ? |
|
Another part of the spec was to be able to mark activity types as not deletable if for example people use them in automated action. I agree it is an advanced use case but according to me you should probably ask before reverting code that harms no-one. Or is it obvious for people they will have to manually create xml ids for records to keep ? Or should they wait for the famous "ORM team will find a solution" ? Many thanks for your input anyway, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is a non-sense. By using the same logic, it should be added
to any low level model.
Replace the check by a simple verification of presence of an XMLID.
A more generic opt-in solution should be integrated into ORM.
Partially revert commits 0db0e66 and
bbd64c2.
See #29257 odoo/enterprise#3550