New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] base_import: unscoped self can bear side effects #31793
[FIX] base_import: unscoped self can bear side effects #31793
Conversation
c835e86
to
cd170be
Compare
cd170be
to
6a4d092
Compare
6a4d092
to
dd20de5
Compare
dd20de5
to
91b47a9
Compare
91b47a9
to
e8a3292
Compare
e8a3292
to
f2939ce
Compare
f2939ce
to
a5226c4
Compare
a5226c4
to
b7a397d
Compare
b7a397d
to
6b1fb55
Compare
6b1fb55
to
e0f6736
Compare
Access to an unscoped self (global context) can bear side effects. This does not happen in standard Odoo, however in one instance, I found a leaked self in the global context which obviously did not conform to what is expected to be accessed here. self beeing volatile it is probably an utterly bad idea to fetch it from the global context. This PR access the windows invariant keyword instead.
e0f6736
to
1b46b08
Compare
Dear @blaggacao, Thank you for your contribution but the version 12.0 is no longer supported. We apology if we could not look at your request in time. This is an automated message. |
Access to an unscoped self (global context) can bear side effects.
This does not happen in standard Odoo, however in one instance, I found
a leaked self in the global context which obviously did not conform to
what is expected to be accessed here. self beeing volatile it is probably
an utterly bad idea to fetch it from the global context.
This PR access the windows invariant keyword instead.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
window
is accessed instead (maybe there is still a more suitable variable, butwindow
does the trick)--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@xoe-labs