Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master mail fix proposals awa #31813

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@awa-odoo
Copy link
Contributor

commented Mar 13, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Mar 13, 2019

@C3POdoo C3POdoo added the RD label Mar 13, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:master-mail-fix-proposals-awa branch 2 times, most recently Mar 13, 2019

@robodoo robodoo added the CI 🤖 label Mar 13, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:master-mail-fix-proposals-awa branch to 13a0d39 Mar 14, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 14, 2019

@awa-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

[EDIT] This will be addressed in another task, ignore the following message.

For the person reviewing this (probably from the discuss team):

Since I've added the "im_status" in the direct message autocomplete propositions, the method get_static_mention_suggestions is not easy to handle.

I've added the 'im_status' value in its result but since the static suggestions (as the name suggests) are only loaded once, it means that if you don't refresh your page every so often, you will get wrong im_status (since the person might be disconnected for a long time).

I did not pass the im_status on the first version of the PR, then I added it, and now I'm not really sure what's best anymore, I'm open to suggestions.

If that's unclear don't hesitate to ask.

@awa-odoo awa-odoo force-pushed the odoo-dev:master-mail-fix-proposals-awa branch from 13a0d39 to 6e4f6c2 Mar 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 25, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:master-mail-fix-proposals-awa branch from 6e4f6c2 to 64ee867 Mar 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 25, 2019

[IMP] mail: fix mailing lists proposals
Task #49261

Purpose
=======

Allow inviting any res.partner on mailing lists channels

Specification
=============

1. Inviting people
  - should be linked to the groups
    (i.e.: if I restrict to people belonging to employees,
    show employees only)
  - should display all available partners if public or not group-based,
    not only users

2. In the channel configuration, tab "Members", the "Recipient" field
   is now mandatory

@awa-odoo awa-odoo force-pushed the odoo-dev:master-mail-fix-proposals-awa branch from 64ee867 to 7e6b458 Apr 24, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.