Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] barcodes: let focus in number, password, tel, phone inputs #31841

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@adr-odoo
Copy link
Contributor

commented Mar 14, 2019

Before this commit, users wasn't able to input values in some
input elements like password, email and phone in mobile.

Steps to reproduce:

  • Go to user
  • Select Preferences
  • Select Change password
  • Try to input something
    => The focus was lost and the keyboard disappeared

In fact, a hidden input always have the focus when no other fields
need it. This input is used to intercept a value from a barcode
scanner.

So now, we added some input types to avoid to set the focus on the
barcode input.

opw-1936712
opw-1948266

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@adr-odoo adr-odoo requested a review from pparidans Mar 14, 2019

@robodoo robodoo added the seen 🙂 label Mar 14, 2019

@C3POdoo C3POdoo added the OE label Mar 14, 2019

@adr-odoo adr-odoo force-pushed the odoo-dev:11.0-barcodes-focus-adr branch 2 times, most recently from bcdd4ea to 1f2e521 Mar 18, 2019

[FIX] barcodes: let focus in number, password, tel, phone inputs
Before this commit, users wasn't able to input values in some
input elements like password, email and phone in mobile.

Steps to reproduce:
- Go to user
- Select Preferences
- Select Change password
- Try to input something
=> The focus was lost and the keyboard disappeared

In fact, a hidden input always have the focus when no other fields
need it. This input is used to intercept a value from a barcode
scanner.

So now, we added some input types to avoid to set the focus on the
barcode input.

The barcode input is now always defined (even if not used in desktop)
to be able to mock a Chrome mobile environment in a test.

opw-1936712
opw-1948266

@adr-odoo adr-odoo force-pushed the odoo-dev:11.0-barcodes-focus-adr branch from 1f2e521 to 33bac8e Mar 18, 2019

@pparidans
Copy link
Contributor

left a comment

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[FIX] barcodes: let focus in number, password, tel, phone inputs
Before this commit, users wasn't able to input values in some
input elements like password, email and phone in mobile.

Steps to reproduce:
- Go to user
- Select Preferences
- Select Change password
- Try to input something
=> The focus was lost and the keyboard disappeared

In fact, a hidden input always have the focus when no other fields
need it. This input is used to intercept a value from a barcode
scanner.

So now, we added some input types to avoid to set the focus on the
barcode input.

The barcode input is now always defined (even if not used in desktop)
to be able to mock a Chrome mobile environment in a test.

opw-1936712
opw-1948266

closes #31841

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

@adr-odoo adr-odoo deleted the odoo-dev:11.0-barcodes-focus-adr branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.