Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] sale: improvement in payment reference #31853

Closed
wants to merge 1 commit into from
Closed

[IMP] sale: improvement in payment reference #31853

wants to merge 1 commit into from

Conversation

sza-odoo
Copy link

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 14, 2019
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 14, 2019
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from 40c7479 to f940b09 Compare March 26, 2019 07:14
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 26, 2019
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from f940b09 to a1ca7bc Compare March 26, 2019 09:03
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 26, 2019
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from a1ca7bc to 73c38a6 Compare March 26, 2019 11:38
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Mar 26, 2019
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from 73c38a6 to f6d728e Compare April 4, 2019 04:54
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 4, 2019
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from f6d728e to 1779379 Compare April 5, 2019 10:42
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 5, 2019
@JKE-be
Copy link
Contributor

JKE-be commented Apr 9, 2019

@robodoo r+

@JKE-be
Copy link
Contributor

JKE-be commented Apr 9, 2019

@robodoo r-

@JKE-be
Copy link
Contributor

JKE-be commented Apr 9, 2019

Please, amend your commit:

[XXX] <module>: <Description>

[IMP] sale: Improvement in payment reference for wire transfer
93235ff 
Purpose of this task is,
Default payment ref for wire transfer is confusing and not really helpful as it will induce encoding errors customer side

So, I removed modulo part in payment reference

Task Id : 1946656
Closes : odoo#31853
@sza-odoo sza-odoo force-pushed the master-sale-payment-reference-improvement-sza branch from 1779379 to 93235ff Compare April 9, 2019 10:34
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 9, 2019
@sza-odoo
Copy link
Author

sza-odoo commented Apr 9, 2019

@JKE-be Commit message updated. Thanks

@JKE-be JKE-be changed the title [IMP]sale : improvement in payment reference [IMP] sale: improvement in payment reference Apr 9, 2019
@JKE-be
Copy link
Contributor

JKE-be commented Apr 9, 2019

@robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 9, 2019
robodoo pushed a commit that referenced this pull request Apr 9, 2019
[IMP] sale: Improvement in payment reference for wire transfer
be8af5d 
Purpose of this task is,
Default payment ref for wire transfer is confusing and not really helpful as it will induce encoding errors customer side

So, I removed modulo part in payment reference

Task Id : 1946656
Closes : #31853

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 9, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 9, 2019
@fw-bot fw-bot deleted the master-sale-payment-reference-improvement-sza branch October 19, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sza-odoo @JKE-be @robodoo @C3POdoo