Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stock: inefficient traceability domain #31901

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@xmo-odoo
Copy link
Collaborator

commented Mar 18, 2019

@sle-odoo this is the complement of #31086 for the downstream domain, the two branches are almost identical so we might as well fix both.

@xmo-odoo xmo-odoo requested a review from sle-odoo Mar 18, 2019

@robodoo robodoo added the seen 🙂 label Mar 18, 2019

[FIX] stock: inefficient traceability domain
PR #31086 converted the not-downstream traceability domain to use a
filter instead as =/!= False on an o2m can lead to memory issues due
to the way they're currently implemented / transformed. This also
converts the downstream versiom just in case and to limit deviations
between the branches.

Co-Authored-By: Daniel Reis <dgreis@sapo.pt>

@xmo-odoo xmo-odoo force-pushed the odoo-dev:11.0-inefficient-domain-xmo branch from a2e75d8 to 208e29f Mar 18, 2019

@C3POdoo C3POdoo added the RD label Mar 18, 2019

@xmo-odoo

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 18, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[FIX] stock: inefficient traceability domain
PR #31086 converted the not-downstream traceability domain to use a
filter instead as =/!= False on an o2m can lead to memory issues due
to the way they're currently implemented / transformed. This also
converts the downstream versiom just in case and to limit deviations
between the branches.

Co-Authored-By: Daniel Reis <dgreis@sapo.pt>

closes #31901

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@@ -92,8 +92,7 @@ def get_lines(self, line_id=None, **kw):
('lot_id', '=', context.get('active_id')),
('location_id.usage', '!=', 'internal'),
('state', '=', 'done'),
('move_id.returned_move_ids', '=', False),

This comment has been minimized.

Copy link
@moylop260

moylop260 Mar 18, 2019

Contributor

Is not faster a domain using “move_id != False” as now you are expecting a valid move_id

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Staging failed: timed out (>120 minutes)

@KangOl

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 18, 2019

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[FIX] stock: inefficient traceability domain
PR #31086 converted the not-downstream traceability domain to use a
filter instead as =/!= False on an o2m can lead to memory issues due
to the way they're currently implemented / transformed. This also
converts the downstream versiom just in case and to limit deviations
between the branches.

Co-Authored-By: Daniel Reis <dgreis@sapo.pt>

closes #31901

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.