Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: fix authorized message #31903

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@johandem
Copy link
Contributor

johandem commented Mar 18, 2019

Description of the issue/feature this PR addresses:

Remove usage of non-existing field auth_msg. This seems to be an uncaught mistake since the field never existed.

Current behavior before PR:

Field auth_msg is used but does not exist, potentially triggering runtime errors.

Desired behavior after PR is merged:

Usage of auth_msg is removed and the fallback message is displayed.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@johandem johandem force-pushed the odoo-dev:12.0-fix-authorized-msg-jde branch from 2a68111 to 9f6053f Mar 18, 2019

johandem added a commit to odoo-dev/odoo that referenced this pull request Mar 18, 2019

[FIX] website_sale: fix authorized message
Field `auth_msg` never existed, this is an uncaught mistake. This commit
removes its usage and displays the fallback message to avoid runtime
error.

Closes odoo#31903

@robodoo robodoo added the seen 🙂 label Mar 18, 2019

[FIX] website_sale: fix authorized message
Field `auth_msg` never existed, this is an uncaught mistake. This commit
removes its usage and displays the fallback message to avoid runtime
error.

Closes #31903

Co-authored-by: Marius Stedjan <marius@stedjan.com>

@C3POdoo C3POdoo added the RD label Mar 18, 2019

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

@johandem johandem requested a review from tbe-odoo Mar 19, 2019

@johandem johandem force-pushed the odoo-dev:12.0-fix-authorized-msg-jde branch from 9f6053f to f592ecb Mar 19, 2019

@robodoo robodoo removed the CI 🤖 label Mar 19, 2019

@tbe-odoo
Copy link
Contributor

tbe-odoo left a comment

robodoo pushed a commit that referenced this pull request Mar 19, 2019

[FIX] website_sale: fix authorized message
Field `auth_msg` never existed, this is an uncaught mistake. This commit
removes its usage and displays the fallback message to avoid runtime
error.

Closes #31903

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>


Co-authored-by: Marius Stedjan <marius@stedjan.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/481946)

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Mar 19, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 19, 2019

@robodoo robodoo closed this in 36435b4 Mar 19, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Merged, thanks!

@KangOl KangOl deleted the odoo-dev:12.0-fix-authorized-msg-jde branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.