Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail: increasing width of pictures & attachments in chat #31904

Conversation

Projects
None yet
4 participants

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

@C3POdoo C3POdoo added the RD label Mar 18, 2019

@kma-odoo kma-odoo force-pushed the odoo-dev:master-mail-increase-width-pictures-pdf-kma branch from eee5575 to 7c5d3e2 Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@kma-odoo

This comment has been minimized.

Copy link
Author

commented Mar 18, 2019

@alexkuhn I've done the changes.
Can you please check?

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-increase-width-pictures-pdf-kma branch from 7c5d3e2 to 287a357 Mar 18, 2019

@alexkuhn

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@robodoo robodoo added the r+ 👌 label Mar 18, 2019

@alexkuhn

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@robodoo robodoo removed the r+ 👌 label Mar 18, 2019

@alexkuhn

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

float should be avoided most of time. The solution with absolute positioning that I suggest was not good enough, because the name clips with the cross icon.

As said in the related task, the best solution would be to use CSS flexbox, but this requires a refactoring of the design.

In the end, let's use float in order to have the minimal diff for this task, while not having the clipping issue. There is a redesign of discuss in progress that should remove all "float" and turn them into clean flexbox equivalent styles.

Sorry again for requesting changes and reverting them.

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

@kma-odoo kma-odoo force-pushed the odoo-dev:master-mail-increase-width-pictures-pdf-kma branch from 287a357 to bfe372f Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@alexkuhn
Copy link
Contributor

left a comment

Don't think the float:none; is necessary for image attachments.
Note that there's also clipping with the name of image attachments and the download icon, because the download icon uses absolute positioning. I don't think this PR should concerned by this issue, but I might be wrong.

Show resolved Hide resolved addons/mail/static/src/scss/composer.scss Outdated

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

[IMP] mail: bigger attachment previews in chat window
Purpose of the task is to increase the size of attachment previews
in chat windows.

Task-ID 1941601

@kma-odoo kma-odoo force-pushed the odoo-dev:master-mail-increase-width-pictures-pdf-kma branch from bfe372f to f60c25f Mar 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 19, 2019

@alexkuhn

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@robodoo robodoo added the r+ 👌 label Mar 19, 2019

robodoo pushed a commit that referenced this pull request Mar 19, 2019

[IMP] mail: bigger attachment previews in chat window
Purpose of the task is to increase the size of attachment previews
in chat windows.

Task-ID 1941601

closes #31904

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.