Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale: terms on vendor bills #31905

Closed

Conversation

Projects
None yet
5 participants
@Julien00859
Copy link
Contributor

commented Mar 18, 2019

Create a vendor bill from documents, change the partner, the default
terms and conditions are automatically set on the bill.

The problem is due to a wrong default value, the onchange only uses
the invoice type from the environment but never from the invoice itself.

opw-1936083

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@Julien00859 Julien00859 requested a review from simongoffin Mar 18, 2019

@robodoo robodoo added the seen 🙂 label Mar 18, 2019

@C3POdoo C3POdoo added the OE label Mar 18, 2019

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

Welcome back ! :p

@robodoo robodoo added the CI 🤖 label Mar 18, 2019

[FIX] sale: terms on vendor bills
Create a vendor bill from documents, change the partner, the default
terms and conditions are automatically set on the bill.

The problem is due to a wrong default value, the onchange only uses
the invoice type from the environment but never from the invoice itself.

opw-1936083

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1936083-term_on_backend-juc branch from 903380a to 4b68fae Mar 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 18, 2019

@simongoffin

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] sale: terms on vendor bills
Create a vendor bill from documents, change the partner, the default
terms and conditions are automatically set on the bill.

The problem is due to a wrong default value, the onchange only uses
the invoice type from the environment but never from the invoice itself.

opw-1936083

closes #31905

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Staging failed: ci/runbot on 2dad10450c8b970a054703333708780254652575 (view more at http://runbot.odoo.com/runbot/build/483679)

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 21, 2019

@robodoo robodoo closed this in 78d351a Mar 21, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Merged, thanks!

@Julien00859 Julien00859 deleted the odoo-dev:12.0-opw-1936083-term_on_backend-juc branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.