Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website: restore default h1 color in customize dialog #31909

Closed

Conversation

Projects
None yet
2 participants
@qsm-odoo
Copy link
Contributor

qsm-odoo commented Mar 18, 2019

Since the bootstrap update that was merged with
754ec44
the customize theme dialog was showing transparent colors for the
headings. This was because bootstrap changed the value of the related
variable from 'inherit' to 'null' to avoid an useless css rule if the
headings are supposed to have the same color as the body text.

[FIX] website: restore default h1 color in customize dialog
Since the bootstrap update that was merged with
754ec44
the customize theme dialog was showing transparent colors for the
headings. This was because bootstrap changed the value of the related
variable from 'inherit' to 'null' to avoid an useless css rule if the
headings are supposed to have the same color as the body text.

@qsm-odoo qsm-odoo self-assigned this Mar 18, 2019

@robodoo robodoo added the seen 🙂 label Mar 18, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Mar 18, 2019

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[FIX] website: restore default h1 color in customize dialog
Since the bootstrap update that was merged with
754ec44
the customize theme dialog was showing transparent colors for the
headings. This was because bootstrap changed the value of the related
variable from 'inherit' to 'null' to avoid an useless css rule if the
headings are supposed to have the same color as the body text.

closes #31909

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

@qsm-odoo qsm-odoo deleted the odoo-dev:master-fix-customize-headings-qsm branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.