Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock: traceback on routes report #31938

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@svs-odoo
Copy link
Contributor

svs-odoo commented Mar 19, 2019

As putaway strategies were replaced by putaway rules, some properties
were renamed but were unchanged in the report, causing traceback.

opw-1957005

@svs-odoo

This comment has been minimized.

Copy link
Contributor Author

svs-odoo commented Mar 19, 2019

@sle-odoo, can you review that and merge it if it's ok ? Thanks

header_lines[location.id]['putaway'].append(putaway)
if location.putaway_rule_ids:
for putaway in location.putaway_rule_ids:
header_lines[location.id]['putaway'].append(putaway)

This comment has been minimized.

Copy link
@sle-odoo

sle-odoo Mar 19, 2019

Contributor

not sure it is acting the same as before

This comment has been minimized.

Copy link
@svs-odoo

svs-odoo Mar 20, 2019

Author Contributor

I changed that, thanks

@svs-odoo svs-odoo force-pushed the odoo-dev:master-fix-routes-report-svs branch from 82f8eca to b349365 Mar 20, 2019

@robodoo robodoo removed the CI 🤖 label Mar 20, 2019

[FIX] stock: traceback on routes report
As putaway strategies were replaced by putaway rules, some properties
were renamed but were unchanged in the report, causing traceback.

opw-1957005

@svs-odoo svs-odoo force-pushed the odoo-dev:master-fix-routes-report-svs branch from b349365 to ec10bca Mar 20, 2019

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor

pimodoo commented Mar 20, 2019

@sle-odoo LGTM

@sle-odoo

This comment has been minimized.

Copy link
Contributor

sle-odoo commented Mar 20, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 20, 2019

robodoo pushed a commit that referenced this pull request Mar 20, 2019

[FIX] stock: traceback on routes report
As putaway strategies were replaced by putaway rules, some properties
were renamed but were unchanged in the report, causing traceback.

opw-1957005

closes #31938

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 20, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.