Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saas 12.2 fix uom mrp #31950

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Whenrow
Copy link
Contributor

commented Mar 19, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] mrp: missing default uom
purpose: on a MO, producing via the 'Produce' wizard give the ability to add any additionnal product into the production. 
The issue is that the UoM of the new line is empty and so will trigger an error later in the flow. 
This commit add a new onchange on product_id to ensure the field product_uom_id will be set accordingly

@Whenrow Whenrow requested a review from amoyaux Mar 19, 2019

@robodoo robodoo added the seen 🙂 label Mar 19, 2019

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.2-fix-uom-mrp branch from d4dc9ed to 8126a17 Mar 19, 2019

@amoyaux

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 19, 2019

@C3POdoo C3POdoo added the RD label Mar 19, 2019

@robodoo robodoo added the CI 🤖 label Mar 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Linked pull request(s) odoo/enterprise#3855 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Mar 20, 2019

[FIX] mrp: missing default uom
purpose: on a MO, producing via the 'Produce' wizard give the ability to add any additionnal product into the production. 
The issue is that the UoM of the new line is empty and so will trigger an error later in the flow. 
This commit add a new onchange on product_id to ensure the field product_uom_id will be set accordingly

closes #31950

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 20, 2019

Whenrow added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[FIX] mrp: missing default uom
purpose: on a MO, producing via the 'Produce' wizard give the ability to add any additionnal product into the production.
The issue is that the UoM of the new line is empty and so will trigger an error later in the flow.
This commit add a new onchange on product_id to ensure the field product_uom_id will be set accordingly

closes odoo#31950

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.