Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale: force maximum section/subtotal width #31951

Closed

Conversation

Projects
None yet
4 participants
@Julien00859
Copy link
Contributor

Julien00859 commented Mar 19, 2019

Step to reproduce:

  • Install sale (sale_management) and studio (web_studio)
  • Change the document template (settings > configuration > general
    settings) to select the second one
  • Go to an order form
  • Enable studio, select "Reports" in the right tab
  • Edit the "Quotation/Order" report, add a new colomn
  • Back to the order form, enable dev mode and add a section to the order
    lines.
  • Print the report => the section is not using all the available place.

The section/subtotal are using a colspan to use all the place in the
table, this colspan is hardcoded to 5, the number of columns without
customization. Adding a new column doesn't change that value.

The fix has been to force the colspan at 99, the maximum value for
colspans. Using that value will always render the row to fill the table.

opw-1936088

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] sale: force maximum section/subtotal width
Step to reproduce:
- Install sale (sale_management) and studio (web_studio)
- Change the document template (settings > configuration > general
settings) to select the second one
- Go to an order form
- Enable studio, select "Reports" in the right tab
- Edit the "Quotation/Order" report, add a new colomn
- Back to the order form, enable dev mode and add a section to the order
lines.
- Print the report => the section is not using all the available place.

The section/subtotal are using a colspan to use all the place in the
table, this colspan is hardcoded to 5, the number of columns without
customization. Adding a new column doesn't change that value.

The fix has been to force the colspan at 99, the maximum value for
colspans. Using that value will always render the row to fill the table.

opw-1936088

@Julien00859 Julien00859 requested a review from nle-odoo Mar 19, 2019

@robodoo robodoo added the seen 🙂 label Mar 19, 2019

@nle-odoo
Copy link
Contributor

nle-odoo left a comment

seems this has been discussed and even if it is ugly this would be the solution we want

robodoo delegate+ V.C.

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Mar 19, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 19, 2019

@C3POdoo C3POdoo added the OE label Mar 19, 2019

@robodoo robodoo added the CI 🤖 label Mar 19, 2019

@robodoo robodoo closed this in 716ff76 Mar 19, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

Merged, thanks!

@Julien00859 Julien00859 deleted the odoo-dev:12.0-opw-1936088-report_font_size-juc branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.