Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_holidays: allow to create leaves with no validation #31952

Conversation

Projects
None yet
4 participants
@tbe-odoo
Copy link
Contributor

tbe-odoo commented Mar 19, 2019

  • The creation of leaves using "no validation" are not possible
    if the SUPERUSER is not in the "Holidays / Team Leader" because
    the validation is made using sudo.

OPW-1951316

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@tbe-odoo tbe-odoo requested a review from KangOl Mar 19, 2019

@robodoo robodoo added the seen 🙂 label Mar 19, 2019

@C3POdoo C3POdoo added the OE label Mar 19, 2019

@tbe-odoo

This comment has been minimized.

Copy link
Contributor Author

tbe-odoo commented Mar 19, 2019

@robodoo robodoo added the r+ 👌 label Mar 19, 2019

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Mar 19, 2019

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Mar 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

'ci/runbot' failed on this reviewed PR.

1 similar comment
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 19, 2019

'ci/runbot' failed on this reviewed PR.

[FIX] hr_holidays: allow to create leaves with no validation
- The creation of leaves using "no validation" are not possible
  if the `SUPERUSER` is not in the "Holidays / Team Leader" because
  the validation is made using `sudo`.

OPW-1951316

@tbe-odoo tbe-odoo force-pushed the odoo-dev:saas-12.1-fix-no-validation-leaves-tbe branch from c108fe0 to b660ce1 Mar 20, 2019

@robodoo robodoo removed the r+ 👌 label Mar 20, 2019

@tbe-odoo

This comment has been minimized.

Copy link
Contributor Author

tbe-odoo commented Mar 20, 2019

robodoo pushed a commit that referenced this pull request Mar 20, 2019

[FIX] hr_holidays: allow to create leaves with no validation
- The creation of leaves using "no validation" are not possible
  if the `SUPERUSER` is not in the "Holidays / Team Leader" because
  the validation is made using `sudo`.

OPW-1951316

closes #31952

Signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 20, 2019

Staging failed: ci/runbot on 6e0f7ac8e7bde2a271ef7b131ded58310b8ad610 (view more at http://runbot.odoo.com/runbot/build/482810)

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Mar 20, 2019

@robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 20, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.