Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] web: correctly reuse read_group old datapoint #31956

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mge-odoo
Copy link
Contributor

mge-odoo commented Mar 19, 2019

Rev. 5c6a7c9 made a change to reuse an old group datapoint when
performing a read_group, instead of restoring some properties of the old
group (so basically a _.omit instead of a _.pick).

This is a bad idea as some properties were bound to the new datapoint
(evaluateModifiers for example) so it doesn't make any sense to update
the old datapoint with theses properties.

@mge-odoo mge-odoo requested a review from aab-odoo Mar 19, 2019

@robodoo robodoo added the CI 🤖 label Mar 19, 2019

@C3POdoo C3POdoo added the RD label Mar 19, 2019

[REF] web: correctly reuse read_group old datapoint
Rev. 5c6a7c9 made a change to reuse an old group datapoint when
performing a read_group, instead of restoring *some* properties of the old
group (so basically a `_.omit` instead of a `_.pick`).

This is a bad idea as some properties were bound to the new datapoint
(`evaluateModifiers` for example) so it doesn't make any sense to update
the old datapoint with theses properties.

@mge-odoo mge-odoo force-pushed the odoo-dev:master-read-group-ref-mge branch from 69d03a9 to ca1e412 Mar 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 20, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor Author

mge-odoo commented Mar 25, 2019

@aab-odoo r+?

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Mar 25, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 25, 2019

robodoo pushed a commit that referenced this pull request Mar 25, 2019

[REF] web: correctly reuse read_group old datapoint
Rev. 5c6a7c9 made a change to reuse an old group datapoint when
performing a read_group, instead of restoring *some* properties of the old
group (so basically a `_.omit` instead of a `_.pick`).

This is a bad idea as some properties were bound to the new datapoint
(`evaluateModifiers` for example) so it doesn't make any sense to update
the old datapoint with theses properties.

closes #31956

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

@robodoo robodoo added error 🙅 and removed CI 🤖 r+ 👌 labels Mar 25, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 25, 2019

Unable to stage PR (set_ref failed(502, None))

@mge-odoo

This comment has been minimized.

Copy link
Contributor Author

mge-odoo commented Mar 26, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Mar 26, 2019

robodoo pushed a commit that referenced this pull request Mar 26, 2019

[REF] web: correctly reuse read_group old datapoint
Rev. 5c6a7c9 made a change to reuse an old group datapoint when
performing a read_group, instead of restoring *some* properties of the old
group (so basically a `_.omit` instead of a `_.pick`).

This is a bad idea as some properties were bound to the new datapoint
(`evaluateModifiers` for example) so it doesn't make any sense to update
the old datapoint with theses properties.

closes #31956

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 26, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.