Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][FIX] website_slides: clean course and lesson pages layout and fix various small UX issues #31977

Conversation

Projects
None yet
5 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Mar 20, 2019

Purpose of this merge is to at last perform a cleaning of layout and design for
eLearning pages still not completely updated with magic layout touch.

Impacted pages

  • course (channel) main page: better top and banner, better navigation.
    Improve training content list display, clean documentation content list
    display and navigation;
  • lesson (slide) main not-fullscreen page;
  • lesson (slide) fullscreen page / widget;
  • homepage: clean navigation;

This merge also contains various fixes and UX improvements for fullscreen
lesson display as well as user profile page. Thanks to @stefanorigano and
@qmo-odoo for their input.

This merge closes tasks 1941250 about fixes and layouting of new eLearning
application. Thanks for your attention.

@robodoo robodoo added the seen 🙂 label Mar 20, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from fc059e1 to 353a161 Mar 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 20, 2019

@C3POdoo C3POdoo added the RD label Mar 20, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from 340beb3 to 40f6113 Mar 20, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 20, 2019

[FIX] website_rating: fix rating popupcomposer display
Improve overall widget layout, fix stars design and perform some small
tweaks.

Commit linked to task ID 1941250 and PR odoo#31977 .

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from 40f6113 to b3b5ff0 Mar 20, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 20, 2019

[FIX] website_rating: fix rating popupcomposer display
Improve overall widget layout, fix stars design and perform some small
tweaks.

Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 20, 2019

[REF] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 20, 2019

[REF] website_slides: course layout + content list
Commit linked to task ID 1941250 and PR odoo#31977 .

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 20, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from b3b5ff0 to 68e9749 Mar 21, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[FIX] website_rating: fix rating popupcomposer display
Improve overall widget layout, fix stars design and perform some small
tweaks.

Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: course layout + content list
Commit linked to task ID 1941250 and PR odoo#31977 .

@robodoo robodoo removed the CI 🤖 label Mar 21, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from 68e9749 to 3b2f64c Mar 21, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: course layout + content list
Commit linked to task ID 1941250 and PR odoo#31977 .

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch from 3b2f64c to c4716b1 Mar 21, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[FIX] website_rating: fix rating popupcomposer display
Improve overall widget layout, fix stars design and perform some small
tweaks.

Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various fullscreen layout issues
Improve overall widget layout, perform some small tweaks. Also remove
top title as it is not wanted.

Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR odoo#31977 .

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: course layout + content list
Commit linked to task ID 1941250 and PR odoo#31977 .

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch 2 times, most recently from e206c01 to 2459ba2 Mar 21, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 21, 2019

[REF] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR odoo#31977 .

robodoo pushed a commit that referenced this pull request Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: improve documentation course layout and not ful…
…lscreen lesson page

Purpose of this commit is to perform a cleaning of

 * documentation course: add a new specific navigation for documentation
   course with a sort option and filters on slide types; clean overall layout
   of documentation course to have a better-looking result as this page was
   still not really updated;
 * lesson not fullscreen page: global layout and cleaning of not-fullscreen
   page to have a better-looking result. Notably related slides for
   documentation slide is set on right, and some UX bits are tweakes;

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] websiste_slides: perform small tweaks on elearning homepage
In Top menu, replace 'My courses' with 'Search' and adapt responsivness
for small devices. Truncate card's description and perform minors design
tweaks. Also add some slides-specific layouting to email validation banner.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides[_survey]: fix various fullscreen issues
This commit provides a few fixes for the fullscreen view:
  * make external links associated with a slide clickable again in fullscreen
    mode;
  * hide completion icons if not member:
  * add margin to subquiz icon in header;
  * add dedicated button to exit the fullscreen mode;
  * change "Pass certification" button to "Test Certification" if not member
    of the channel (for website publishers);

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various quiz-related issues
This commit provides a few fixes for quiz feature:

  * fix amount of karma won by the user in a quiz;
  * correctly display the fact that a subquiz was completed by the user instead
    of just looking like a non-completed quiz;
  * going on a previously completed quiz, good answers are hightlighted and
    inputs disabled;
  * effectively put the quiz in readonly mode if not a channel member.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various non-fullscreen view issues
This commit provides a few fixes for the non-fullscreen view:

  * remove the subquiz link on slides of type 'quiz' in the sidebar;
  * hide completion icons in sidebar if not member;
  * only show the 'embed on your website' option when a slide has an embed
    code. This will prevent slides of type 'certification' or 'quiz' to
    display an empty embed box;

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: remove reference to google+ in lesson statistic…
…s update

Let us consider this great social network is not necessary anymore.

Commit linked to task ID 1941250 and PR #31977

robodoo added a commit that referenced this pull request Mar 21, 2019

[MERGE][FIX] website_slides: clean course and lesson pages layout and…
… fix various small UX issues

Purpose of this merge is to at last perform a cleaning of layout and design for
eLearning pages still not completely updated with magic layout touch.

Impacted pages
 * course (channel) main page: better top and banner, better navigation.
   Improve training content list display, clean documentation content list
   display and navigation;
 * lesson (slide) main not-fullscreen page;
 * lesson (slide) fullscreen page / widget;
 * homepage: clean navigation;

This merge also contains various fixes and UX improvements for fullscreen
lesson display as well as user profile page. Thanks to @stefanorigano and
@qmo-odoo for their input.

This merge closes tasks 1941250 about fixes and layouting of new eLearning
application. Thanks for your attention.

closes #31977

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_rating: fix rating popupcomposer display
Improve overall widget layout, fix stars design and perform some small
tweaks.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_profile: improve top banner and navigation and apply va…
…rious tweaks

Improve the email validation banner and allow adding custom classes when
calling its templates. Also improve top banner design as well as navigation
and tabs.

Finally perform some minor tweaks on design.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various fullscreen layout issues
Improve overall widget layout, perform some small tweaks. Also remove
top title as it is not wanted.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix course navigation design
Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: improve course overall layout and training cont…
…ent list

Purpose of this commit is to improve the global look of course layout
(notably banner, navigation, course / channel informations). Content list
layout displayed in training (orderable) is also tweaked and improved.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[REF] website_slides: cleanup scss ordering, remove unused classes, a…
…dd placeholder images

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: improve documentation course layout and not ful…
…lscreen lesson page

Purpose of this commit is to perform a cleaning of

 * documentation course: add a new specific navigation for documentation
   course with a sort option and filters on slide types; clean overall layout
   of documentation course to have a better-looking result as this page was
   still not really updated;
 * lesson not fullscreen page: global layout and cleaning of not-fullscreen
   page to have a better-looking result. Notably related slides for
   documentation slide is set on right, and some UX bits are tweakes;

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] websiste_slides: perform small tweaks on elearning homepage
In Top menu, replace 'My courses' with 'Search' and adapt responsivness
for small devices. Truncate card's description and perform minors design
tweaks. Also add some slides-specific layouting to email validation banner.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides[_survey]: fix various fullscreen issues
This commit provides a few fixes for the fullscreen view:
  * make external links associated with a slide clickable again in fullscreen
    mode;
  * hide completion icons if not member:
  * add margin to subquiz icon in header;
  * add dedicated button to exit the fullscreen mode;
  * change "Pass certification" button to "Test Certification" if not member
    of the channel (for website publishers);

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various quiz-related issues
This commit provides a few fixes for quiz feature:

  * fix amount of karma won by the user in a quiz;
  * correctly display the fact that a subquiz was completed by the user instead
    of just looking like a non-completed quiz;
  * going on a previously completed quiz, good answers are hightlighted and
    inputs disabled;
  * effectively put the quiz in readonly mode if not a channel member.

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: fix various non-fullscreen view issues
This commit provides a few fixes for the non-fullscreen view:

  * remove the subquiz link on slides of type 'quiz' in the sidebar;
  * hide completion icons in sidebar if not member;
  * only show the 'embed on your website' option when a slide has an embed
    code. This will prevent slides of type 'certification' or 'quiz' to
    display an empty embed box;

Commit linked to task ID 1941250 and PR #31977

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] website_slides: remove reference to google+ in lesson statistic…
…s update

Let us consider this great social network is not necessary anymore.

Commit linked to task ID 1941250 and PR #31977

robodoo added a commit that referenced this pull request Mar 21, 2019

[MERGE][FIX] website_slides: clean course and lesson pages layout and…
… fix various small UX issues

Purpose of this merge is to at last perform a cleaning of layout and design for
eLearning pages still not completely updated with magic layout touch.

Impacted pages
 * course (channel) main page: better top and banner, better navigation.
   Improve training content list display, clean documentation content list
   display and navigation;
 * lesson (slide) main not-fullscreen page;
 * lesson (slide) fullscreen page / widget;
 * homepage: clean navigation;

This merge also contains various fixes and UX improvements for fullscreen
lesson display as well as user profile page. Thanks to @stefanorigano and
@qmo-odoo for their input.

This merge closes tasks 1941250 about fixes and layouting of new eLearning
application. Thanks for your attention.

closes #31977

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 21, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 21, 2019

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:saas-12.2-elearning-fiximp-tde-12 branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.