Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging.11.0 #31981

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
7 participants
@diamondcare
Copy link

commented Mar 20, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

nim-odoo and others added some commits May 18, 2018

[FIX] mrp: write on done WO
Do not allow to write on a done WO except for time log.

Partial backport of aafa049

opw-1946121

closes #31917

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
[IMP] core: avoid to process work when worker is 'killed' during sleep.
If a signal is received during the worker _runloop sleep,
the worker will be marked as alive=False but process_work
will still be called once.

This commit prevents that by checking the worker state before
calling process_work.

closes #31885

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
[FIX] payment_stripe: open>exit>open opened 1 time
If using Stripe we did "Pay Now" -> close modal -> "Pay Now" we would
get 2 modals and possibly be blocked by infinite loading.

With this changeset, we only execute one time our strip.js file so we do
not declare multiple MutationObserver.

We also only open one checkout at a time from stripe when closing and
opening it or multiclicking click (the later one that could block the
interface with several stripe iframe opened and one with a infinite
loading wheel).

opw-1939323
closes #31928

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
[FIX] web_editor: review drag and drop in the editor
Forward-port of be689c5
was missed from 11.0.

closes #31971

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
[FIX] fleet: expired contract
- Create a contract for a vehicle
- Renew the contract and set old one to closed
- Run the cron 'Fleet: Generate contracts costs based on costs
  frequency'

The closed contract is reset to expired.

The contract should remain closed.

opw-1949470

closes #31974

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
force rebuild
uniquifier: uA6HzdPDZQ38Lg2r
@wtaferner

This comment has been minimized.

Copy link
Contributor

commented on 98fe505 Mar 21, 2019

@nle-odoo @nim-odoo @odony
This is really the worst fix I have ever seen in stable. Breaking payment is a no go without proper testing and as the renaming was risky it broke the Javascript execution.

There are still two places with the old variable name...I will provide a PR in a few minutes, after testing...

This comment has been minimized.

Copy link
Contributor Author

replied Mar 21, 2019

@wtaferner You are correct, I am testing this: #32026

edit:

Sorry, this was tested but not before the renaming of handler to stripeHandler had been done (that was intended to avoid conflict on having a local "handler" in the whole module closure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.