Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] purchase: fix error when creating new quotation of purchase #31983

Conversation

Projects
None yet
4 participants
@pka-odoo
Copy link
Contributor

pka-odoo commented Mar 20, 2019

  • in purchase there are 3 fields that computes by '_amount_all', so it is called 3 times. but, round method has 'ensure_one' therefore it gives singleton error.

  • So, removed rounding as there is need of rounding explicitly since these are monetary fields which will be rounded automatically.

Related to Issue: 1948645

Description of the issue/feature this PR addresses:
Traceback when creating new quotation from purchase aggrements

Current behavior before PR:
Traceback when creating new quotation from purchase aggrements

Desired behavior after PR is merged:
Traceback resolved when creating new quotation from purchase aggrements

Issue:
https://www.odoo.com/web#id=1948645&action=327&model=project.task&view_type=form&menu_id=4720

Pad:
https://pad.odoo.com/p/r.4ee8640ed26691650fc5c75a86206211

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] purchase: fix error when creating new quotation of purchase
- in purchase there are 3 fields that computes by '_amount_all', so it is called 3 times. but, round method has 'ensure_one' therefore it gives singleton error.

- So, removed rounding as there is need of rounding explicitly since these are monetary fields which will be rounded automatically.

Related to Issue: 1948645

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

@C3POdoo C3POdoo added the RD label Mar 20, 2019

@sle-odoo

This comment has been minimized.

Copy link
Contributor

sle-odoo commented Apr 3, 2019

@pka-odoo this patch looks fishy, currency_id is required on the order
can you have a look again/explain the issue a little more?i don't get it

@pka-odoo pka-odoo closed this Apr 4, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.