Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: tests: exclude domain from message_id #31987

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Icallhimtest
Copy link
Contributor

commented Mar 20, 2019

If the database name contains one of the tested strings, it can render
the assertion of the test invalid or inconclusive. Ensure we strip it
away during the tests.

opw: 1957055

The traceback from Odoo.sh:

03/20/2019 11:54:26 | ERROR | server | `   File "/home/odoo/src/odoo/addons/mail/tests/test_mail_gateway.py", line 1166, in test_forward_parent_id
03/20/2019 11:54:26 | ERROR | server | `     self.assertNotIn('-%d-' % msg.res_id, msg.message_id)
03/20/2019 11:54:26 | ERROR | server | ` AssertionError: '-11-' unexpectedly found in '<206056256894899.1553079262.698772430419922-openerp-reply_to@l10n-dominicana-11-0-325031>'
[FIX] mail: tests: exclude domain from message_id
If the database name contains one of the tested strings, it can render
the assertion of the test invalid or inconclusive. Ensure we strip it
away during the tests.

opw: 1957055

@C3POdoo C3POdoo added the OE label Mar 20, 2019

@Icallhimtest Icallhimtest requested a review from tde-banana-odoo Mar 20, 2019

@Icallhimtest

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@tde-banana-odoo if you think of a cleaner way than splitting and taking the first element, feel free to make the modification and merge it.

Thanks!

@Icallhimtest

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@Icallhimtest

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@tde-banana-odoo pompidom

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Staging failed: ci/runbot on 3cab8a15000b345252f6544d571a02ed07aafc47 (view more at http://runbot.odoo.com/runbot/build/485199)

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@robodoo r+ retry

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

I'm sorry, @tde-banana-odoo. This PR is already reviewed, reviewing it again is useless.

robodoo pushed a commit that referenced this pull request Mar 25, 2019

[FIX] mail: tests: exclude domain from message_id
If the database name contains one of the tested strings, it can render
the assertion of the test invalid or inconclusive. Ensure we strip it
away during the tests.

opw: 1957055

closes #31987

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 25, 2019

remihb added a commit to osiell/OCB that referenced this pull request Mar 28, 2019

[FIX] mail: tests: exclude domain from message_id
If the database name contains one of the tested strings, it can render
the assertion of the test invalid or inconclusive. Ensure we strip it
away during the tests.

opw: 1957055

closes odoo#31987

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.