Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: html field with long links #31988

Closed

Conversation

Projects
None yet
4 participants
@pparidans
Copy link
Contributor

commented Mar 20, 2019

When adding a long link in a task's description the line starts to
overflow from the field and create an horizontal scroll.

This commit restores the CSS word-wrap properties to the form field html
allowing to nicely break the line on a word basis, preventing a possible
overflow.

Also it doesn't make sense to apply it on an iframe.

Task ID: 1942179

@robodoo robodoo added the seen 🙂 label Mar 20, 2019

@pparidans pparidans requested a review from adr-odoo Mar 20, 2019

@C3POdoo C3POdoo added the RD label Mar 20, 2019

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

[FIX] web_editor: html field with long links
Following the refactoring of the web_editor (JS & CSS) when adding a
long link in a task's description the line starts to overflow from the
field and create an horizontal scroll.

This commit restores the CSS word-wrap properties to the form field html
allowing to nicely break the line on a word basis, preventing a possible
overflow.

Also it doesn't make sense to apply it on an iframe.

Task ID: 1942179

@pparidans pparidans force-pushed the odoo-dev:saas-12.2-fix-html-field-wrap-app branch from 8600cbe to 1bc39e5 Mar 21, 2019

@robodoo robodoo removed the CI 🤖 label Mar 21, 2019

@adr-odoo
Copy link
Contributor

left a comment

robodoo pushed a commit that referenced this pull request Mar 21, 2019

[FIX] web_editor: html field with long links
Following the refactoring of the web_editor (JS & CSS) when adding a
long link in a task's description the line starts to overflow from the
field and create an horizontal scroll.

This commit restores the CSS word-wrap properties to the form field html
allowing to nicely break the line on a word basis, preventing a possible
overflow.

Also it doesn't make sense to apply it on an iframe.

Task ID: 1942179

closes #31988

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 21, 2019

@pparidans pparidans deleted the odoo-dev:saas-12.2-fix-html-field-wrap-app branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.