Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_payroll: Approving a leave deletes overlapping benefits #31997

Closed

Conversation

Projects
None yet
3 participants
@LucasLefevre
Copy link
Contributor

commented Mar 20, 2019

Steps to reproduce:

  1. Generate Benefits for one month
    (Don't validate them)

  2. Create and validate a leave in that month

Current behavior: Benefits overlapping the leave are not deleted.
Expected behaviour: Benefits are deleted and a new benefit
of type leave is created instead.

Fix: compute conflicting benefits before approving
a leave to allow the normal conflict resolution
mechanism to handle the issue.

Note: this fix is sub-optimal and a better fix should be
done in master.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] hr_payroll: Appoving a leave delete overlapping benefits
Steps to reproduce:

1. Generate Benefits for one month
(Don't validate them)

2. Create and validate a leave in that month

Current behavior: Benefits overlapping the leave are not deleted.
Expected behaviour: Benefits are deleted and a new benefit
of type leave is created instead.

Fix: compute conflicting benefits before approving
a leave to allow the normal conflict resolution
mechanism to handle the issue.

Note: this fix is suboptimal and a better fix should be
done in master.

@robodoo robodoo added the seen 🙂 label Mar 20, 2019

@C3POdoo C3POdoo added the RD label Mar 20, 2019

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

@LucasLefevre LucasLefevre changed the title [FIX] hr_payroll: Approving a leave delete overlapping benefits [FIX] hr_payroll: Approving a leave deletes overlapping benefits Mar 21, 2019

@LucasLefevre

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

@tivisse Could you check this fix for saas-12.1.
Thanks :)

@LucasLefevre

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Actually, I'm not sure it is an issue. You are not supposed to approve a leave if benefits have been generated. It means the leave is in the past

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.