Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] event: add sequence on event categories #32010

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@fja-odoo
Copy link

commented Mar 21, 2019

Reorganise the categories of the events sorting them by sequence.
Same behavior as "eCommerce Product categories".

Related to task-1917687

@robodoo robodoo added the seen 🙂 label Mar 21, 2019

@qsm-odoo qsm-odoo requested a review from JKE-be Mar 21, 2019

@robodoo robodoo added the CI 🤖 label Mar 21, 2019

@fja-odoo fja-odoo force-pushed the odoo-dev:master-category-event-website-fja branch from cbf9763 to d8f0aa6 Mar 21, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 21, 2019

Show resolved Hide resolved addons/event/models/event.py Outdated
@seb-odoo
Copy link
Contributor

left a comment

It looks like the code works as expected, so that's a good first step!

I still add a lot of comments so I can give you all the possible tips. Especially all the comments about get_event_type_sequence are only informative because you should remove the method if read_group orders correctly.

Show resolved Hide resolved addons/event/models/event.py Outdated
Show resolved Hide resolved addons/website_event/controllers/main.py Outdated
Show resolved Hide resolved addons/website_event/controllers/main.py Outdated
Show resolved Hide resolved addons/website_event/controllers/main.py Outdated
Show resolved Hide resolved addons/event/views/event_views.xml
Show resolved Hide resolved addons/website_event/controllers/main.py Outdated

@fja-odoo fja-odoo force-pushed the odoo-dev:master-category-event-website-fja branch from d8f0aa6 to dba6a58 Mar 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 22, 2019

@fja-odoo fja-odoo force-pushed the odoo-dev:master-category-event-website-fja branch from dba6a58 to 8f86568 Mar 25, 2019

@robodoo robodoo removed the CI 🤖 label Mar 25, 2019

@fja-odoo fja-odoo changed the title [IMP] event, website_event: sequence ordering added on event categories [IMP] event :adds sequence on event categories Mar 25, 2019

@robodoo robodoo added the CI 🤖 label Mar 25, 2019

@seb-odoo seb-odoo self-requested a review Mar 25, 2019

@seb-odoo
Copy link
Contributor

left a comment

One last thing for the commit message, the first line:

  • space after and not before :
  • and conjugate verb to follow "this commit will"

See https://www.odoo.com/documentation/master/reference/guidelines.html#commit-message-header

-> [IMP] event: add sequence on event categories

[IMP] event: add sequence on event categories
Reorganise the categories of the events sorting them by sequence.
Same behavior as "eCommerce Product categories".

Related to task-1917687

@fja-odoo fja-odoo force-pushed the odoo-dev:master-category-event-website-fja branch from 8f86568 to eadee82 Mar 25, 2019

@fja-odoo fja-odoo changed the title [IMP] event :adds sequence on event categories [IMP] event: add sequence on event categories Mar 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 25, 2019

@fja-odoo

This comment has been minimized.

Copy link
Author

commented Apr 2, 2019

@JKE-be ma pr est toujours ouverte!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.