Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly filter product taxes in multicompany case #32030

Open
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
5 participants
@gdgellatly
Copy link
Contributor

gdgellatly commented Mar 22, 2019

Description of the issue/feature this PR addresses:

In a multicompany environment, particularly if using any kind of intercompany rules often the user is either sudo or has multicompany access. As a result, when accessing product taxes it can return a result or results for other companies, forgoing the 2nd and 3rd leg of tax determination.

Give accounts and company are company specific, no filtering is required for these.

Current behavior before PR:
If a product has a tax set or one company, which a user has access to, while creating an invoice for another company, the tax will be found, then filtered out, resulting in no taxes.

Desired behavior after PR is merged:
Only ever consider taxes of the relevant company.

resolves #27696

\cc @qdp-odoo

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza
Copy link
Contributor

pedrobaeza left a comment

The or part is not activated if taxes from other company are found, but not from intended one.

@gdgellatly

This comment has been minimized.

Copy link
Contributor Author

gdgellatly commented Apr 4, 2019

Note: I don't like the fix, just the code is a bit longwinded to keep it as it was

opw-1963881

@mart-e mart-e added the Accounting label Apr 8, 2019

@gdgellatly gdgellatly force-pushed the gdgellatly:patch-5 branch from 15e7b7b to 6379509 Apr 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 9, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Apr 15, 2019

@gdgellatly please fix the commit message to respect our guidelines

Otherwise I agree with the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.