Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_sale(_coupon): improve promo code alert style #32061

Closed
wants to merge 1 commit into from

Conversation

seb-odoo
Copy link
Contributor

By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@seb-odoo seb-odoo added RD research & development, internal work Website labels Mar 22, 2019
@seb-odoo seb-odoo self-assigned this Mar 22, 2019
@seb-odoo seb-odoo requested a review from qsm-odoo March 22, 2019 17:36
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Mar 22, 2019
By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 2, 2019
@seb-odoo
Copy link
Contributor Author

seb-odoo commented Apr 4, 2019

@qsm-odoo reminder

@seb-odoo seb-odoo changed the title [IMP] website_sale: improve promo code alert style [IMP] website_sale(_coupon): improve promo code alert style Apr 4, 2019
Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo robodoo added the r+ 👌 label Apr 4, 2019
robodoo pushed a commit that referenced this pull request Apr 4, 2019
By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".

closes #32061

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 4, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 4, 2019
@seb-odoo seb-odoo deleted the master-alert-style-seb branch April 15, 2019 09:32
@seb-odoo seb-odoo restored the master-alert-style-seb branch April 15, 2019 09:32
@seb-odoo seb-odoo deleted the master-alert-style-seb branch April 18, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants