Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_sale(_coupon): improve promo code alert style #32061

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@seb-odoo
Copy link
Contributor

seb-odoo commented Mar 22, 2019

By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@seb-odoo seb-odoo self-assigned this Mar 22, 2019

@robodoo robodoo added the seen 🙂 label Mar 22, 2019

@seb-odoo seb-odoo requested a review from qsm-odoo Mar 22, 2019

@robodoo robodoo added the CI 🤖 label Mar 22, 2019

[IMP] website_sale(_coupon): improve promo code alert style
By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".

@seb-odoo seb-odoo force-pushed the odoo-dev:master-alert-style-seb branch from 9916fe5 to 3a59546 Apr 2, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 2, 2019

@seb-odoo

This comment has been minimized.

Copy link
Contributor Author

seb-odoo commented Apr 4, 2019

@qsm-odoo reminder

@seb-odoo seb-odoo changed the title [IMP] website_sale: improve promo code alert style [IMP] website_sale(_coupon): improve promo code alert style Apr 4, 2019

@qsm-odoo
Copy link
Contributor

qsm-odoo left a comment

@robodoo robodoo added the r+ 👌 label Apr 4, 2019

robodoo pushed a commit that referenced this pull request Apr 4, 2019

[IMP] website_sale(_coupon): improve promo code alert style
By using proper BS4 classes for alert, so it looks better and it is more
compatible with themes.

Also removed the unused "Option not available".

closes #32061

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 4, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 4, 2019

@seb-odoo seb-odoo deleted the odoo-dev:master-alert-style-seb branch Apr 15, 2019

@seb-odoo seb-odoo restored the odoo-dev:master-alert-style-seb branch Apr 15, 2019

@seb-odoo seb-odoo deleted the odoo-dev:master-alert-style-seb branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.