Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account_check_printing: Fix traceback on onchange #32068

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@sswapnesh
Copy link
Contributor

commented Mar 23, 2019

Description of the issue/feature this PR addresses: #32064

Current behavior before PR:
Method amount_to_text() cannot be called with empty records set due to self.ensure_one()

See Issue #32064 for detailed description

Desired behavior after PR is merged: No traceback on onchange

Closes: #32064

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@luisg123v

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

I see this is a similar fix as #29865. I don't know why there are two identical onchanges on payment models, instead of having only one on account.abstract.payment (maybe a design error?).

@sswapnesh on the other hand, I believe this should target 11.0, as the issue affects also that version.

@sswapnesh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

@sswapnesh on the other hand, I believe this should target 11.0, as the issue affects also that version.

I think they can add same commit on v11 too if not than I will create new PR for 11 and which will be forward ported to v12.

Let's see what Odoo says on this

@Yenthe666

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

@sswapnesh it is better to make fixes against the lowest possible version. Odoo will automatically forward port, backports are not done very often honestly. Going with forward ports is cleaner than backports.

@sswapnesh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

@sswapnesh it is better to make fixes against the lowest possible version. Odoo will automatically forward port, backports are not done very often honestly. Going with forward ports is cleaner than backports.

Added #32071 for v11

@luisg123v

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

@sswapnesh why not just change the base branch of this PR? It makes no sense to have two different PRs with the same patch.

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Closing as #32202 is merged.

@pedrobaeza pedrobaeza closed this Mar 28, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Mar 28, 2019

@sswapnesh sswapnesh deleted the sswapnesh:patch-8 branch Mar 28, 2019

@sswapnesh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Closing as #32202 is merged.

You were too fast to Close this one.
(But you missed to close #32064 😉)

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

I don't get you. Do you mean that I shouldn't close this one?

@sswapnesh

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

I don't get you. Do you mean that I shouldn't close this one?

No, You hit Close button here just a second ago I tried to close this.

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Ah, OK! Yes, I'm very fast closing this, you know, hehe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.