Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mrp: make product_tracking readonly to avoid write operation #32070

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@Yenthe666
Copy link
Contributor

commented Mar 23, 2019

Description of the issue/feature this PR addresses: The readonly=False will trigger writes on product.template and product.product
Fixes #32033

Current behavior before PR: As the field product_tracking is not a readonly it triggers a write on the product.template and product.product model while it can just be a readonly related field that holds the value of the product.

Desired behavior after PR is merged: The field is a readonly (default for compute) and there is no unwanted write operation

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@fmdl

fmdl approved these changes Mar 23, 2019

@Yenthe666

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

@sle-odoo could you have a look at this small fix please?

@sle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

isn't it already fixed by 8c8b32e ?

@Yenthe666

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

The mrp.product.produce.line record is not readonly, the mrp.product.produce is but the line is still triggering a write operation. Right?

@sle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

oh yes you're right
let's see what @amoyaux thinks since this behaviour was kept in the refactoring of saas12.2

@amoyaux

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

It's correct also for me

@sle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 9, 2019

@robodoo robodoo added the merging 👷 label Apr 9, 2019

@robodoo robodoo closed this in 92313e1 Apr 9, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 9, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Merged, thanks!

@Yenthe666 Yenthe666 deleted the Yenthe666:12-fix-related-field-mrp branch Apr 9, 2019

@Yenthe666

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.