Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: add trick about the 160 limit in the search more view #32072

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
7 participants
@fmdl
Copy link
Contributor

fmdl commented Mar 23, 2019

Description of the issue/feature this PR addresses:
Dear all, it is a simple little trick to help the user about the 160 harcoded limit.

Desired behavior after PR is merged:
Goto on a m2o field, click on "Search More"
image

After removing the filter, all the records can be find. (Note press enter in the search have the same behahior).
image

Solve : #28975, #29708, #12001 and #1386

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@fmdl fmdl changed the title [WIP][FIX] web: add trick about the 160 limit in the search more view [FIX] web: add trick about the 160 limit in the search more view Mar 23, 2019

@fmdl

This comment has been minimized.

Copy link
Contributor Author

fmdl commented Mar 23, 2019

@Yenthe666

This comment has been minimized.

Copy link
Contributor

Yenthe666 commented Mar 23, 2019

Hmm this might actually be a cool idea. @mart-e and @ged-odoo what do you think? With this PR it would at least be clear that there is a limited result and that if you remove the filter you'll get everything.
CC @pedrobaeza

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Mar 23, 2019

Well, this is not exactly the solution, as it's UX confusing: if you click on "Search more..." with something input in the field, the search will be limited through the name_search of that input, but removing that filter you will get all records, so the solution would be to have 2 filters: one for current input and this second one.

@Yenthe666

This comment has been minimized.

Copy link
Contributor

Yenthe666 commented Mar 23, 2019

Good point Pedro. I don't think this is a fully finished PR but I think this is the right time to discuss it and change something for the future though. The amount of reports that have been made in the past show that quite some people don't get it - or don't know it - so changing it is probably a good idea.
This feels like a good first step :)

@pedrobaeza

This comment has been minimized.

Copy link
Contributor

pedrobaeza commented Mar 23, 2019

As said, removing the limit is not possible right now, but yes, clarifying the situation in the popup would help. I don't think any way that improving things for hammering the server with "full searches" is the way to go, but let's see Odoo's opinion.

This behavior has served me to "correct" users for not abusing the search more, using it for performing all searches, and instead teaching them for using wildcard (%) for finding exactly from the widget what they need.

@luisg123v

This comment has been minimized.

Copy link
Contributor

luisg123v commented Mar 23, 2019

This was exactly my point. I understand why that limit exists, but IMO there should be anything to prevent users from getting confused about it.

@ged-odoo

This comment has been minimized.

Copy link
Contributor

ged-odoo commented Mar 23, 2019

@aab-odoo and myself did actually talk about this a few weeks/months ago (?). The idea was to display a filter, a little bit like this PR. I however do not remember exactly what was the result of this conversation/short prototype.

This issue is at the same time very simple, in some way, but quite subtle also. Many people (myself included), tried to solve it, in different ways. But no solution so far is an improvement on all aspects of the issue. That is why we kept the 'status quo'.

Maybe @aab-odoo will remember more details.

@fmdl

This comment has been minimized.

Copy link
Contributor Author

fmdl commented Mar 24, 2019

I have add the name_value in the filter name,
image

But the best is to have some thing like that :
image

@robodoo robodoo removed the CI 🤖 label Mar 24, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Mar 25, 2019

Hello.

This commit provides a solution to the issue. It is actually following the same idea as @fmdl suggested. It has been merged a few weeks ago and is available as of saas-12.1.

Regards.

@aab-odoo aab-odoo closed this Mar 25, 2019

@robodoo robodoo added the closed 💔 label Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.