Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n_in: Add demo data #32077

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@jip-odoo
Copy link

commented Mar 25, 2019

Description of the issue/feature this PR addresses:

Task : https://www.odoo.com/web?#id=1948171&action=327&model=project.task&view_type=form&menu_id=4720
Pad : https://pad.odoo.com/p/r.bb7e8111b0a6db8eb8450c406393043c

Description : Remove required because it's creating an error while editing the product and that is not
legally required

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Mar 25, 2019

@C3POdoo C3POdoo added the RD label Mar 25, 2019

@sswapnesh
Copy link
Contributor

left a comment

Blank line at the end of file.

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 4c5302b to 1372de6 Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 1372de6 to 4d4d0be Mar 27, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 27, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 4d4d0be to 08c679d Mar 28, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 28, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 08c679d to 874e1f9 Apr 8, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 8, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 874e1f9 to f1c25ef Apr 9, 2019

@robodoo robodoo removed the CI 🤖 label Apr 9, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from f1c25ef to d5c206e Apr 9, 2019

@robodoo robodoo added the CI 🤖 label Apr 9, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from d5c206e to 114e4e8 Apr 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 9, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 114e4e8 to da3b102 Apr 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 11, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from da3b102 to 9479a76 Apr 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 17, 2019

@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Hi @jip-odoo

Can you reword your commit please

MOD ?
And message is no more correct.
Now the field is no more required!

Once done, please ping me.

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 9479a76 to ca82709 Apr 18, 2019

@robodoo robodoo removed the CI 🤖 label Apr 18, 2019

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from ca82709 to 8049026 Apr 18, 2019

@robodoo robodoo added the CI 🤖 label Apr 18, 2019

jip-odoo added some commits Mar 20, 2019

[ADD] l10n_in(_pos,_sale,_stock): add demo data
 - Add demo data in the field HSN/SAC Code and HSN Description into the products.

Related Task : 1948171
[FIX] l10n_in: remove required
- Purpose of this task is to remove required attribute on HSN field because that is not more required.
- before applied this commit if set up an indian company, we have an error if we edit a product because of HSN field is required.

Related Task: 1948171

@jip-odoo jip-odoo force-pushed the odoo-dev:master-l10n_in-HSN-data-jip branch from 8049026 to 229d5c2 Apr 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 19, 2019

@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

@robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Apr 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Apr 19, 2019

[FIX] l10n_in: remove required
- Purpose of this task is to remove required attribute on HSN field because that is not more required.
- before applied this commit if set up an indian company, we have an error if we edit a product because of HSN field is required.

Related Task: 1948171

closes #32077

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 19, 2019

@rdeodoo rdeodoo deleted the odoo-dev:master-l10n_in-HSN-data-jip branch Apr 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.