Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] point_of_sale: fix decimal point #32089

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@switch87
Copy link
Contributor

switch87 commented Mar 25, 2019

Before this fix there was no check if there was already a decimal point
in the value when using the onscreen keypad.

Fixes #32034

Steps to reproduce:

  • Open up POS interface
  • Add an item
  • Press the decimal point button multiple times (2 or more)
  • Note that pressing additional number keys do not display
  • Backspace must be pressed for the number of digits entered,
    plus the multiple decimal points, to clear
    all the hidden characters in the value buffer
  • Same behavior occurs with the Discount and Price
    values

Current behavior:
Multiple decimal point characters can be
"entered" and are inserted into value buffer
(Qty, Disc, or Price), but do not display on
screen.
Additional digits entered after multiple decimal
point presses are inserted into buffer, but do
not display on screen.
Additional digits entered after the last valid
digit on the screen are also inserted into the
buffer.
Backspace must be used to remove the invisible
characters from the value buffer.

Expected behavior:
The value buffer for Qty, Disc, or Price should
more closely match what is displayed on the
screen.
Characters which are invalid and aren't
displayed on the screen, should not be inserted
into the value buffer, including the decimal
point button.

@switch87 switch87 requested review from mart-e and nim-odoo Mar 25, 2019

@robodoo robodoo added the seen 🙂 label Mar 25, 2019

@C3POdoo C3POdoo added the RD label Mar 25, 2019

@robodoo robodoo added the CI 🤖 label Mar 25, 2019

@switch87 switch87 requested review from pha-odoo and removed request for mart-e and nim-odoo Apr 9, 2019

@switch87

This comment has been minimized.

Copy link
Contributor Author

switch87 commented Apr 9, 2019

@pha-odoo can you review this?

@pha-odoo

This comment has been minimized.

Copy link

pha-odoo commented Apr 9, 2019

ok

@switch87

This comment has been minimized.

Copy link
Contributor Author

switch87 commented Apr 9, 2019

[FIX] point_of_sale: fix decimal point
Before this fix there was no check if there was already a decimal point
in the value when using the onscreen keypad.

Fixes #32034

Steps to reproduce:

* Open up POS interface
* Add an item
* Press the decimal point button multiple times (2 or more)
* Note that pressing additional number keys do not display
* Backspace must be pressed for the number of digits entered,
  plus the multiple decimal points, to clear
  all the hidden characters in the value buffer
* Same behavior occurs with the Discount and Price
  values

Current behavior:
Multiple decimal point characters can be
"entered" and are inserted into value buffer
(Qty, Disc, or Price), but do not display on
screen.
Additional digits entered after multiple decimal
point presses are inserted into buffer, but do
not display on screen.
Additional digits entered after the last valid
digit on the screen are also inserted into the
buffer.
Backspace must be used to remove the invisible
characters from the value buffer.

Expected behavior:
The value buffer for Qty, Disc, or Price should
more closely match what is displayed on the
screen.
Characters which are invalid and aren't
displayed on the screen, should not be inserted
into the value buffer, including the decimal
point button.
@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Apr 9, 2019

@switch87 switch87 force-pushed the odoo-dev:10.0-pos-fix-decimal-gpe branch from d583af5 to da8b81c Apr 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 9, 2019

@switch87

This comment has been minimized.

Copy link
Contributor Author

switch87 commented Apr 9, 2019

@qle-odoo I think robodoo will not listen, I pushed a rewritten commit-message at the same moment you r+'d 😭

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Apr 9, 2019

@robodoo robodoo added the r+ 👌 label Apr 9, 2019

robodoo pushed a commit that referenced this pull request Apr 9, 2019

[FIX] point_of_sale: fix decimal point
Before this fix there was no check if there was already a decimal point
in the value when using the onscreen keypad.

Fixes #32034

Steps to reproduce:

* Open up POS interface
* Add an item
* Press the decimal point button multiple times (2 or more)
* Note that pressing additional number keys do not display
* Backspace must be pressed for the number of digits entered,
  plus the multiple decimal points, to clear
  all the hidden characters in the value buffer
* Same behavior occurs with the Discount and Price
  values

Current behavior:
Multiple decimal point characters can be
"entered" and are inserted into value buffer
(Qty, Disc, or Price), but do not display on
screen.
Additional digits entered after multiple decimal
point presses are inserted into buffer, but do
not display on screen.
Additional digits entered after the last valid
digit on the screen are also inserted into the
buffer.
Backspace must be used to remove the invisible
characters from the value buffer.

Expected behavior:
The value buffer for Qty, Disc, or Price should
more closely match what is displayed on the
screen.
Characters which are invalid and aren't
displayed on the screen, should not be inserted
into the value buffer, including the decimal
point button.

closes #32089

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 9, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 9, 2019

@switch87 switch87 deleted the odoo-dev:10.0-pos-fix-decimal-gpe branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.