Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REV] "[FIX] website: language prefixed URL on website" #32090

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@nle-odoo
Copy link
Contributor

commented Mar 25, 2019

This reverts commit 5324284
This reverts commit ad826f5.

If for example we had in a template:

<script type="text/javascript" src="/payment_stripe/static/src/js/stripe.js"></script>

it has been reproduced to be gotten as:

<script type="text/javascript" src="/de_DE/payment_stripe/static/src/js/stripe.js"></script>

which is unexpected and could cause an error.

[REV] "[FIX] website: language prefixed URL on website"
This reverts commit 5324284
This reverts commit ad826f5.

If for example we had in a template:

 <script type="text/javascript" src="/payment_stripe/static/src/js/stripe.js"></script>

it has been reproduced to be gotten as:

 <script type="text/javascript" src="/de_DE/payment_stripe/static/src/js/stripe.js"></script>

which is unexpected and could cause an error.
closes #32090

@nle-odoo nle-odoo added the OE label Mar 25, 2019

@nle-odoo nle-odoo force-pushed the odoo-dev:11.0-staging-nle branch from 3434386 to 1203fe1 Mar 25, 2019

@robodoo robodoo added the seen 🙂 label Mar 25, 2019

nle-odoo referenced this pull request Mar 25, 2019

[FIX] http_routing: ignore # when checking multilang URL
With 953a693 when a route is not found we assume it is a website.page
that can be multilang.

But with #31792 we should once again prefix URL by the language if
necessary.

The combination of the two cause issue when an url like `/web#home` is
tested since we do not take `#` into account, we check if the route is
multilang but no route `/web#home` is found => so we get
`/fr_FR/web#home`.

With this fix, `#fragment` is not taken into account when searching
route.

related to #31792
related to opw-1922051
closes #32059

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
@nle-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 25, 2019

[REV] "[FIX] website: language prefixed URL on website"
This reverts commit 5324284
This reverts commit ad826f5.

If for example we had in a template:

 <script type="text/javascript" src="/payment_stripe/static/src/js/stripe.js"></script>

it has been reproduced to be gotten as:

 <script type="text/javascript" src="/de_DE/payment_stripe/static/src/js/stripe.js"></script>

which is unexpected and could cause an error.
closes #32090

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 25, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 25, 2019

@nle-odoo nle-odoo deleted the odoo-dev:11.0-staging-nle branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.