Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base: split _get_rendering_context to allow different models #32101

Closed

Conversation

Projects
None yet
4 participants
@jpp-odoo
Copy link
Contributor

commented Mar 25, 2019

Allowing to override the _get_rendering_context and call the new
function (_get_rendreing_context_model) with a different custom model
to render the html.

opw-1946792

@robodoo robodoo added the seen 🙂 label Mar 25, 2019

@jpp-odoo jpp-odoo requested a review from nle-odoo Mar 25, 2019

[FIX] base: split _get_rendering_context to allow different models
Allowing to override the _get_rendering_context and call the new
function (_get_rendreing_context_model) with a different custom model
to render the html.

opw-1946792

@jpp-odoo jpp-odoo force-pushed the odoo-dev:12.0-opw-1946792-open_copy_report-jpp branch from 1a6b00a to 0724a9d Mar 25, 2019

@C3POdoo C3POdoo added the OE label Mar 25, 2019

@robodoo robodoo added the CI 🤖 label Mar 25, 2019

@nle-odoo
Copy link
Contributor

left a comment

Approved with regards to enterprise pr

robodoo delegate+

@jpp-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 26, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Linked pull request(s) odoo/enterprise#3893 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Mar 26, 2019

[FIX] base: split _get_rendering_context to allow different models
Allowing to override the _get_rendering_context and call the new
function (_get_rendreing_context_model) with a different custom model
to render the html.

opw-1946792

closes #32101

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 26, 2019

@nle-odoo nle-odoo deleted the odoo-dev:12.0-opw-1946792-open_copy_report-jpp branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.