Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: modal in modal => no block mobile #32106

Closed

Conversation

Projects
None yet
3 participants
@nle-odoo
Copy link
Contributor

nle-odoo commented Mar 25, 2019

On a form view:

  • we open a modal form view
  • in this modal we open a modal form view
  • we close that second modal

=> the modal is closed and the first one is still opened, but on mobile
we can't scroll to above or below the modal.

This is because bootstrap remove .modal-open class on body when we close
the second modal, but this class is necessary to scroll (this is not
much an issue on desktop since scroll is often not necessary).

We already had a fix that was weakened in 02a063f.

With this changeset, we keep .modal-open as long as a modal is opened.

Without the change, added test failed with:
10. Modal is said opened (expected: true, result: false)

opw-1948423

[FIX] web: modal in modal => no block mobile
On a form view:
- we open a modal form view
- in this modal we open a modal form view
- we close that second modal

=> the modal is closed and the first one is still opened, but on mobile
we can't scroll to above or below the modal.

This is because bootstrap remove .modal-open class on body when we close
the second modal, but this class is necessary to scroll (this is not
much an issue on desktop since scroll is often not necessary).

We already had a fix that was weakened in 02a063f.

With this changeset, we keep .modal-open as long as a modal is opened.

Without the change, added test failed with:
  10. Modal is said opened (expected: true, result: false)

opw-1948423
closes #32106

@nle-odoo nle-odoo added the OE label Mar 25, 2019

@nle-odoo nle-odoo force-pushed the odoo-dev:saas-11.3-web-opw-1948423-nle branch to 8648a5f Mar 25, 2019

@nle-odoo nle-odoo requested a review from VincentSchippefilt Mar 25, 2019

@nle-odoo

This comment has been minimized.

Copy link
Contributor Author

nle-odoo commented Mar 26, 2019

thanks )

robodoo r+

tested one last time on community runbot in mobile mobe

@robodoo robodoo added the r+ 👌 label Mar 26, 2019

robodoo pushed a commit that referenced this pull request Mar 26, 2019

[FIX] web: modal in modal => no block mobile
On a form view:
- we open a modal form view
- in this modal we open a modal form view
- we close that second modal

=> the modal is closed and the first one is still opened, but on mobile
we can't scroll to above or below the modal.

This is because bootstrap remove .modal-open class on body when we close
the second modal, but this class is necessary to scroll (this is not
much an issue on desktop since scroll is often not necessary).

We already had a fix that was weakened in 02a063f.

With this changeset, we keep .modal-open as long as a modal is opened.

Without the change, added test failed with:
  10. Modal is said opened (expected: true, result: false)

opw-1948423
closes #32106

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 26, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 26, 2019

@nle-odoo nle-odoo deleted the odoo-dev:saas-11.3-web-opw-1948423-nle branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.